From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 4/4] gpio: mb86s7x: enable ACPI support Date: Thu, 2 May 2019 11:02:55 +0300 Message-ID: <20190502080255.GS26516@lahna.fi.intel.com> References: <20190429131208.3620-1-ard.biesheuvel@linaro.org> <20190429131208.3620-5-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190429131208.3620-5-ard.biesheuvel@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ard Biesheuvel Cc: Lorenzo Pieralisi , Graeme Gregory , linux-acpi@vger.kernel.org, Marc Zyngier , Linus Walleij , "Rafael J. Wysocki" , linux-gpio@vger.kernel.org, Masahisa Kojima , linux-arm-kernel@lists.infradead.org, Len Brown List-Id: linux-gpio@vger.kernel.org On Mon, Apr 29, 2019 at 03:12:08PM +0200, Ard Biesheuvel wrote: > @@ -160,13 +177,15 @@ static int mb86s70_gpio_probe(struct platform_device *pdev) > if (IS_ERR(gchip->base)) > return PTR_ERR(gchip->base); > > - gchip->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(gchip->clk)) > - return PTR_ERR(gchip->clk); > + if (!ACPI_COMPANION(&pdev->dev)) { Since you don't use the returned ACPI object, you can also use has_acpi_companion(&pdev->dev) here and other similar places. Regardless of that, Reviewed-by: Mika Westerberg