From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings Date: Mon, 13 May 2019 08:44:40 +0100 Message-ID: <20190513074440.GK4319@dell> References: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1557732606-14662-1-git-send-email-amelie.delaunay@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Amelie Delaunay Cc: Linus Walleij , Alexandre Torgue , Maxime Coquelin , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, kbuild-all@01.org, Julia Lawall List-Id: linux-gpio@vger.kernel.org On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 > drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression > compared with zero: type < 0 > > Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Signed-off-by: Amelie Delaunay > --- > drivers/pinctrl/pinctrl-stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already fixed up and pushed. > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index bcd8126..3bd5d6f 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, > struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > u32 param = pinconf_to_config_param(*config); > struct pinctrl_gpio_range *range; > - u32 dir, type, pupd; > + int dir, type, pupd; > u32 arg = 0; > int ret; > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog