* [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
@ 2019-04-28 15:08 Jonathan Neuschäfer
2019-04-30 21:32 ` Christian Lamparter
2019-05-16 12:44 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Jonathan Neuschäfer @ 2019-04-28 15:08 UTC (permalink / raw)
To: linux-arm-msm
Cc: Jonathan Neuschäfer, Andy Gross, David Brown,
Bjorn Andersson, Linus Walleij, Rob Herring, Mark Rutland,
linux-gpio, devicetree, linux-kernel
The property is spelled 'bias-pull-up', as documented in
pinctrl-bindings.txt.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
.../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +-
.../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +-
.../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +-
.../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +-
.../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
index c2dbb3e8d840..4e90ddd77784 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
@@ -42,7 +42,7 @@ information about e.g. the mux function.
The following generic properties as defined in pinctrl-bindings.txt are valid
to specify in a pin configuration subnode:
- pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
+ pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
output-low, output-high.
Non-empty subnodes must specify the 'pins' property.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
index 991be0cd0948..84be0f2c6f3b 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
@@ -44,7 +44,7 @@ information about e.g. the mux function.
The following generic properties as defined in pinctrl-bindings.txt are valid
to specify in a pin configuration subnode:
- pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
+ pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
Non-empty subnodes must specify the 'pins' property.
Note that not all properties are valid for all pins.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
index 7ed56a1b70fc..a7aaaa7db83b 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
@@ -42,7 +42,7 @@ information about e.g. the mux function.
The following generic properties as defined in pinctrl-bindings.txt are valid
to specify in a pin configuration subnode:
- pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
+ pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
output-low, output-high.
Non-empty subnodes must specify the 'pins' property.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
index cdc4787e59d2..f095209848c8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
@@ -42,7 +42,7 @@ information about e.g. the mux function.
The following generic properties as defined in pinctrl-bindings.txt are valid
to specify in a pin configuration subnode:
- pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
+ pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
output-low, output-high.
Non-empty subnodes must specify the 'pins' property.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
index c22e6c425d0b..004056506679 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
@@ -41,7 +41,7 @@ information about e.g. the mux function.
The following generic properties as defined in pinctrl-bindings.txt are valid
to specify in a pin configuration subnode:
- pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
+ pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
Non-empty subnodes must specify the 'pins' property.
Note that not all properties are valid for all pins.
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
2019-04-28 15:08 [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up Jonathan Neuschäfer
@ 2019-04-30 21:32 ` Christian Lamparter
2019-05-02 19:55 ` Rob Herring
2019-05-16 12:44 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Christian Lamparter @ 2019-04-30 21:32 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: linux-arm-msm, Andy Gross, David Brown, Bjorn Andersson,
Linus Walleij, Rob Herring, Mark Rutland, linux-gpio, devicetree,
linux-kernel
On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote:
> The property is spelled 'bias-pull-up', as documented in
> pinctrl-bindings.txt.
>
I also sent out a patch for that... back in 2017:
https://patchwork.ozlabs.org/patch/763151/
It's marked Accepted and Archived.
@rob ?
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> index c2dbb3e8d840..4e90ddd77784 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> index 991be0cd0948..84be0f2c6f3b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> @@ -44,7 +44,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> index 7ed56a1b70fc..a7aaaa7db83b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> index cdc4787e59d2..f095209848c8 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> index c22e6c425d0b..004056506679 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> @@ -41,7 +41,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
2019-04-30 21:32 ` Christian Lamparter
@ 2019-05-02 19:55 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-05-02 19:55 UTC (permalink / raw)
To: Christian Lamparter
Cc: Jonathan Neuschäfer, linux-arm-msm, Andy Gross, David Brown,
Bjorn Andersson, Linus Walleij, Mark Rutland, linux-gpio,
devicetree, linux-kernel
On Tue, Apr 30, 2019 at 11:32:17PM +0200, Christian Lamparter wrote:
> On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote:
> > The property is spelled 'bias-pull-up', as documented in
> > pinctrl-bindings.txt.
> >
>
> I also sent out a patch for that... back in 2017:
>
> https://patchwork.ozlabs.org/patch/763151/
>
> It's marked Accepted and Archived.
>
> @rob ?
No idea what happened besides a problem between the screen and keyboard.
Let me try again...
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
2019-04-28 15:08 [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up Jonathan Neuschäfer
2019-04-30 21:32 ` Christian Lamparter
@ 2019-05-16 12:44 ` Linus Walleij
2019-05-16 13:15 ` Jonathan Neuschäfer
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2019-05-16 12:44 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: MSM, Andy Gross, David Brown, Bjorn Andersson, Rob Herring,
Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org
On Sun, Apr 28, 2019 at 5:08 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> The property is spelled 'bias-pull-up', as documented in
> pinctrl-bindings.txt.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
It appears from Rob's comment that he's applying it,
tell me if I need to apply it to the pinctrl tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
2019-05-16 12:44 ` Linus Walleij
@ 2019-05-16 13:15 ` Jonathan Neuschäfer
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Neuschäfer @ 2019-05-16 13:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Jonathan Neuschäfer, MSM, Andy Gross, David Brown,
Bjorn Andersson, Rob Herring, Mark Rutland,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Thu, May 16, 2019 at 02:44:30PM +0200, Linus Walleij wrote:
> On Sun, Apr 28, 2019 at 5:08 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
>
> > The property is spelled 'bias-pull-up', as documented in
> > pinctrl-bindings.txt.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> It appears from Rob's comment that he's applying it,
> tell me if I need to apply it to the pinctrl tree.
Yes, Rob applied Christian's version to dt/next:
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=c50495aa4cfcaace5f61174ab3069d5047d14f17
So there's no need to apply my version.
Thanks,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-16 13:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-28 15:08 [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up Jonathan Neuschäfer
2019-04-30 21:32 ` Christian Lamparter
2019-05-02 19:55 ` Rob Herring
2019-05-16 12:44 ` Linus Walleij
2019-05-16 13:15 ` Jonathan Neuschäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).