From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: netdev@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-amlogic@lists.infradead.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
devicetree@vger.kernel.org, narmstrong@baylibre.com,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC next v1 3/5] net: stmmac: use GPIO descriptors in stmmac_mdio_reset
Date: Sun, 9 Jun 2019 22:52:45 +0200 [thread overview]
Message-ID: <20190609205245.GC8247@lunn.ch> (raw)
In-Reply-To: <20190609180621.7607-4-martin.blumenstingl@googlemail.com>
> + struct gpio_desc *reset_gpio;
> +
> if (data->reset_gpio < 0) {
> struct device_node *np = priv->device->of_node;
>
> - data->reset_gpio = of_get_named_gpio(np,
> - "snps,reset-gpio", 0);
> - if (data->reset_gpio < 0)
> - return 0;
> + reset_gpio = devm_gpiod_get_optional(priv->device,
> + "snps,reset",
> + GPIOD_OUT_LOW);
> + if (IS_ERR(reset_gpio))
> + return PTR_ERR(reset_gpio);
>
> - data->active_low = of_property_read_bool(np,
> - "snps,reset-active-low");
Hi Martin
I think you need to keep this here. You can then use it to decide how
to change gpio_desc to remove flags that should be ignored.
Andrew
next prev parent reply other threads:[~2019-06-09 20:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 18:06 [RFC next v1 0/5] stmmac: honor the GPIO flags for the PHY reset GPIO Martin Blumenstingl
2019-06-09 18:06 ` [RFC next v1 1/5] net: stmmac: drop redundant check in stmmac_mdio_reset Martin Blumenstingl
2019-06-09 18:06 ` [RFC next v1 2/5] gpio: of: parse stmmac PHY reset line specific active-low property Martin Blumenstingl
2019-06-09 20:38 ` Andrew Lunn
2019-06-09 21:21 ` Martin Blumenstingl
2019-06-09 21:29 ` Linus Walleij
2019-06-09 18:06 ` [RFC next v1 3/5] net: stmmac: use GPIO descriptors in stmmac_mdio_reset Martin Blumenstingl
2019-06-09 20:52 ` Andrew Lunn [this message]
2019-06-09 21:50 ` Linus Walleij
2019-06-09 18:06 ` [RFC next v1 4/5] net: stmmac: use device_property_read_u32_array to read the reset delays Martin Blumenstingl
2019-06-09 18:06 ` [RFC next v1 5/5] arm64: dts: meson: g12a: x96-max: fix the Ethernet PHY reset line Martin Blumenstingl
2019-06-09 21:17 ` Linus Walleij
2019-06-09 21:36 ` Martin Blumenstingl
2019-06-09 22:06 ` Linus Walleij
2019-06-09 22:28 ` Martin Blumenstingl
2019-06-09 20:45 ` [RFC next v1 0/5] stmmac: honor the GPIO flags for the PHY reset GPIO Andrew Lunn
2019-06-09 21:52 ` Linus Walleij
2019-06-09 22:32 ` Martin Blumenstingl
2019-06-10 11:47 ` Maxime Ripard
2019-06-10 12:31 ` Martin Blumenstingl
2019-06-10 13:25 ` Andrew Lunn
2019-06-10 15:52 ` Martin Blumenstingl
2019-06-10 13:51 ` Maxime Ripard
2019-06-10 15:51 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609205245.GC8247@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).