From: Shawn Guo <shawnguo@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Will Deacon <will.deacon@arm.com>, Stefan Agner <stefan@agner.ch>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Anson Huang <anson.huang@nxp.com>,
Olof Johansson <olof@lixom.net>,
Jagan Teki <jagan@amarulasolutions.com>,
dl-linux-imx <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dinh
Subject: Re: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN
Date: Wed, 12 Jun 2019 14:05:29 +0800 [thread overview]
Message-ID: <20190612060522.GB11086@dragon> (raw)
In-Reply-To: <AM0PR04MB421171336B9206D02FF6514080ED0@AM0PR04MB4211.eurprd04.prod.outlook.com>
On Tue, Jun 11, 2019 at 10:00:36AM +0000, Aisheng Dong wrote:
> > From: Linus Walleij [mailto:linus.walleij@linaro.org]
> > Sent: Saturday, June 8, 2019 5:04 AM
> >
> > On Thu, May 30, 2019 at 5:04 AM <Anson.Huang@nxp.com> wrote:
> >
> > > From: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > Add binding doc for i.MX8MN pinctrl driver.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al
> > please look at this!
> >
> > > +Required properties:
> > > +- compatible: "fsl,imx8mn-iomuxc"
> >
> > So should this not be "nxp,imx8mn-iomuxc"
> > or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name
> > is nxp is it not.
> >
> > I was complaining to the DT maintainers at one point that these companies
> > seem to buy each other left and right so this vendor nomenclature is dubious,
> > but I guess at least it should reflect the vendor that produced the chip or
> > something.
> >
> > If everyone is happy with "fsl,*" I will not complain though.
> > (i.e. if the maintainers ACK it.)
>
> We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion.
> And we already did this way for most i.MX devices.
+1
We do not see serious problem with 'fsl' prefix, so would rather stay
with it.
Shawn
prev parent reply other threads:[~2019-06-12 6:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 3:05 [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN Anson.Huang
2019-05-30 3:05 ` [PATCH 2/3] pinctrl: freescale: Add i.MX8MN pinctrl driver support Anson.Huang
2019-06-11 10:45 ` Aisheng Dong
2019-05-30 3:05 ` [PATCH 3/3] arm64: defconfig: Select CONFIG_PINCTRL_IMX8MN by default Anson.Huang
2019-06-11 10:51 ` Aisheng Dong
2019-06-07 21:04 ` [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN Linus Walleij
2019-06-11 10:00 ` Aisheng Dong
2019-06-12 6:05 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612060522.GB11086@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=leonard.crestez@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).