From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1127EC48BD6 for ; Tue, 25 Jun 2019 07:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF08E2089F for ; Tue, 25 Jun 2019 07:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561447860; bh=/QdJpDShT/yWCyXy42YAGFG+PVbKrfugMkhIQqmAP4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vGnmtFzylrZuGbqPChQfbVlcAsiVRsgJybd2YxcMf+XcCp+oqlCzAuRIRreaPkLw6 e4dunifow5xPHgWe80NUbgpeVO5DLdE/zD3t33wQ9CRCiwCNsH1RsG/bj9tY7ZwTfC +b6lIQfTCjhOD8L/LFOVJnJLThGp4gf5qZXvCWAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729193AbfFYHa7 (ORCPT ); Tue, 25 Jun 2019 03:30:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729118AbfFYHa6 (ORCPT ); Tue, 25 Jun 2019 03:30:58 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C87120863; Tue, 25 Jun 2019 07:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561447857; bh=/QdJpDShT/yWCyXy42YAGFG+PVbKrfugMkhIQqmAP4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UHE0jibf9j1D1l6TBM/X56TOxidrIG+agSqI7oHmTprTBS7wHKn7aSMpK+bSm8s0D 7O2AABe2JJs76+UlY8WLUEYOtahYLqikXpK6DtL7zb1TCiZhcwUu1mrDJIkif6/Vcy yt7oJrJR8QzU8kPOnwwzvZqfbr3Zs/nfU0PxrYoM= Date: Tue, 25 Jun 2019 15:30:16 +0800 From: Greg Kroah-Hartman To: Bartosz Golaszewski Cc: "Enrico Weigelt, metux IT consult" , Bartosz Golaszewski , Markus Elfring , Andy Shevchenko , Keerthy , Linus Walleij , "Rafael J. Wysocki" , linux-gpio , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource() Message-ID: <20190625073016.GA18381@kroah.com> References: <20190221162627.3476-1-brgl@bgdev.pl> <9efcbce2-4d49-7197-a3d8-0e83850892d5@web.de> <39ae399a-c606-c6de-f84d-35e39d0410c0@metux.net> <1dd52704-0e41-db31-33f4-c9f446a47344@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Jun 25, 2019 at 09:10:25AM +0200, Bartosz Golaszewski wrote: > pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult > napisał(a): > > > > On 24.06.19 12:46, Bartosz Golaszewski wrote: > > > > >> The patch seems pretty trivial and doesn't change any actual code, so > > >> I don't see hard resons for rejecting it. > > >> > > > > > > In its current form it makes the code even less readable. The #ifdef > > > should actually be one line lower and touch the comment instead of the > > > EXPORT_SYMBOL() related to a different function. > > > > Okay, that missing newline should be fixed (as well as the extra one > > after the #ifdef). Besides that, I don't see any further problems. > > > > Are we sure this even changes something? Does kernel documentation get > generated according to current config options? I really think this > patch just pollutes the history for now apparent reason. > > Greg, could you give your opinion on this? Why are you all arguing with a all-but-instinguishable-from-a-bot persona about a patch that I will never apply? greg k-h