From: Thierry Reding <thierry.reding@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net,
marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch,
mark.rutland@arm.com, pdeschrijver@nvidia.com,
pgaikwad@nvidia.com, sboyd@kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com,
talho@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, mperttunen@nvidia.com,
spatra@nvidia.com, robh+dt@kernel.org, digetx@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume
Date: Tue, 25 Jun 2019 15:40:31 +0200 [thread overview]
Message-ID: <20190625134031.GA22491@ulmo> (raw)
In-Reply-To: <1561345379-2429-4-git-send-email-skomatineni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Sun, Jun 23, 2019 at 08:02:44PM -0700, Sowjanya Komatineni wrote:
> During SC7 resume, PARKED bit clear from the pinmux registers may
> cause a glitch on the GPIO lines.
>
> So, Tegra GPIOs restore should happen prior to restoring Tegra pinmux
> to keep the GPIO lines in a known good state prior to clearing PARKED
> bit.
>
> This patch has fix for this by moving Tegra GPIOs restore to happen
> very early than pinctrl resume.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/gpio/gpio-tegra.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-25 13:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 3:02 [PATCH V4 00/18] SC7 entry and exit support for Tegra210 Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 01/18] irqchip: tegra: do not disable COP IRQ during suspend Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 02/18] pinctrl: tegra: add suspend and resume support Sowjanya Komatineni
2019-06-24 9:46 ` Dmitry Osipenko
2019-06-24 17:34 ` Sowjanya Komatineni
2019-06-26 10:08 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume Sowjanya Komatineni
2019-06-25 13:38 ` Linus Walleij
2019-06-26 17:06 ` Sowjanya Komatineni
2019-06-25 13:40 ` Thierry Reding [this message]
2019-06-24 3:02 ` [PATCH V4 04/18] clk: tegra: save and restore divider rate Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 05/18] clk: tegra: pllout: save and restore pllout context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 06/18] clk: tegra: pll: save and restore pll context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 07/18] clk: tegra: save and restore CPU and System clocks context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 08/18] clk: tegra: support for saving and restoring OSC context Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 09/18] clk: tegra: add suspend resume support for DFLL Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 10/18] clk: tegra: add save and restore context support for peripheral clocks Sowjanya Komatineni
2019-06-26 10:12 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 11/18] clk: tegra210: use fence_udelay during PLLU init Sowjanya Komatineni
2019-06-26 10:12 ` Thierry Reding
2019-06-24 3:02 ` [PATCH V4 12/18] clk: tegra210: support for Tegra210 clocks suspend and resume Sowjanya Komatineni
2019-06-26 10:16 ` Thierry Reding
2019-06-26 16:46 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 13/18] soc/tegra: pmc: allow support for more tegra wake Sowjanya Komatineni
2019-06-24 8:15 ` Marc Zyngier
2019-06-24 16:21 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 14/18] soc/tegra: pmc: add pmc wake support for tegra210 Sowjanya Komatineni
2019-06-26 10:26 ` Thierry Reding
2019-06-26 16:27 ` Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 15/18] arm64: tegra: enable wake from deep sleep on RTC alarm Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 16/18] soc/tegra: pmc: configure core power request polarity Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 17/18] soc/tegra: pmc: configure deep sleep control settings Sowjanya Komatineni
2019-06-24 3:02 ` [PATCH V4 18/18] arm64: dts: tegra210-p2180: Jetson TX1 SC7 timings Sowjanya Komatineni
2019-06-26 10:28 ` Thierry Reding
2019-06-26 16:28 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625134031.GA22491@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jason@lakedaemon.net \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=spatra@nvidia.com \
--cc=stefan@agner.ch \
--cc=talho@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).