* [PATCH] unicore: Drop pointless include
@ 2019-06-26 9:34 Linus Walleij
2019-07-28 9:58 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2019-06-26 9:34 UTC (permalink / raw)
To: linux-gpio; +Cc: Bartosz Golaszewski, Linus Walleij, Guan Xuetao
I can't see why this file includes <linux/gpio.h>, it is not
using any of the interfaces. Lots of things are named "gpio"
in the file but it is an irqchip driver and has nothing to
do with the GPIO interfaces.
Cc: Guan Xuetao <gxt@pku.edu.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/unicore32/kernel/irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/unicore32/kernel/irq.c b/arch/unicore32/kernel/irq.c
index eb1fd0030359..8385e4fc0ff6 100644
--- a/arch/unicore32/kernel/irq.c
+++ b/arch/unicore32/kernel/irq.c
@@ -24,7 +24,6 @@
#include <linux/kallsyms.h>
#include <linux/proc_fs.h>
#include <linux/syscore_ops.h>
-#include <linux/gpio.h>
#include <mach/hardware.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] unicore: Drop pointless include
2019-06-26 9:34 [PATCH] unicore: Drop pointless include Linus Walleij
@ 2019-07-28 9:58 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-07-28 9:58 UTC (permalink / raw)
To: open list:GPIO SUBSYSTEM; +Cc: Bartosz Golaszewski, Guan Xuetao
On Wed, Jun 26, 2019 at 11:34 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> I can't see why this file includes <linux/gpio.h>, it is not
> using any of the interfaces. Lots of things are named "gpio"
> in the file but it is an irqchip driver and has nothing to
> do with the GPIO interfaces.
>
> Cc: Guan Xuetao <gxt@pku.edu.cn>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Patch applied to the GPIO tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-28 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 9:34 [PATCH] unicore: Drop pointless include Linus Walleij
2019-07-28 9:58 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).