From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: Re: [PATCH] Revert "spi: gpio: Don't request CS GPIO in DT use-case"
Date: Tue, 2 Jul 2019 12:39:14 +0100 [thread overview]
Message-ID: <20190702113914.GH2793@sirena.org.uk> (raw)
In-Reply-To: <20190701172517.31641-1-linus.walleij@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Mon, Jul 01, 2019 at 07:25:17PM +0200, Linus Walleij wrote:
> This reverts commit 249e2632dcd0509b8f8f296f5aabf4d48dfd6da8.
>
> After this commit drivers/net/dsa/vitesse-vsc73xx.c stopped
> working. Apparently CS is not working because the reads
> from the device is just returning just 1:s or just 0:s at
> all bisection points, so it is a complete regression and
> I think spi-gpio CS is essentially broken.
Also I'm a bit concerned that nobody else noticed this - do we
have any understanding of what the actual problem is?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-02 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 17:25 [PATCH] Revert "spi: gpio: Don't request CS GPIO in DT use-case" Linus Walleij
2019-07-02 11:35 ` Mark Brown
2019-07-02 11:39 ` Mark Brown [this message]
2019-07-02 13:08 ` Linus Walleij
2019-07-02 19:41 ` Linus Walleij
2019-07-02 13:04 ` Applied "Revert "spi: gpio: Don't request CS GPIO in DT use-case"" to the spi tree Mark Brown
2019-07-02 13:04 ` Applied "spi: gpio: Fix handling of CS GPIO for DT systems" " Mark Brown
2019-07-04 7:00 ` [PATCH] Revert "spi: gpio: Don't request CS GPIO in DT use-case" Linus Walleij
2019-07-04 11:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702113914.GH2793@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox