* [PATCH] gpio: gpiolib-of.c: Add of_node_put() before break
@ 2019-07-06 13:34 Nishka Dasgupta
2019-07-08 12:40 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-07-06 13:34 UTC (permalink / raw)
To: linus.walleij, bgolaszewski, linux-gpio; +Cc: Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/gpio/gpiolib-of.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index aec7bd86ae7e..c9325efc1783 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -154,6 +154,7 @@ static void of_gpio_flags_quirks(struct device_node *np,
of_node_full_name(child));
*flags |= OF_GPIO_ACTIVE_LOW;
}
+ of_node_put(child);
break;
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpiolib-of.c: Add of_node_put() before break
2019-07-06 13:34 [PATCH] gpio: gpiolib-of.c: Add of_node_put() before break Nishka Dasgupta
@ 2019-07-08 12:40 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-07-08 12:40 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: Linus Walleij, linux-gpio
sob., 6 lip 2019 o 15:34 Nishka Dasgupta <nishkadg.linux@gmail.com> napisał(a):
>
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a break from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the break.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/gpio/gpiolib-of.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index aec7bd86ae7e..c9325efc1783 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -154,6 +154,7 @@ static void of_gpio_flags_quirks(struct device_node *np,
> of_node_full_name(child));
> *flags |= OF_GPIO_ACTIVE_LOW;
> }
> + of_node_put(child);
> break;
> }
> }
> --
> 2.19.1
>
Applied for fixes with a slightly changed commit message. Thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-06 13:34 [PATCH] gpio: gpiolib-of.c: Add of_node_put() before break Nishka Dasgupta
2019-07-08 12:40 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).