linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: "Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Jeffrey Hugo" <jeffrey.l.hugo@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	gpio <linux-gpio@vger.kernel.org>,
	DT <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: msm8998: Squash TSIF pins together
Date: Mon, 22 Jul 2019 17:53:00 -0600	[thread overview]
Message-ID: <20190722235300.GA24879@bogus> (raw)
In-Reply-To: <503b2ae8-ead6-70cd-7b21-ce5f5166a23a@free.fr>

On Thu, Jul 04, 2019 at 10:57:06AM +0200, Marc Gonzalez wrote:
> TSIF is the Transport Stream Interface.
> First, rename tsif1 to tsif0, and tsif2 to tsif1.
> Then squash all 5 tsif0 pins into a single function.
> Same for tsif1.

Doesn't this break backwards compatibility? If so, you should say so and 
say why that's okay for this platform. In any case, whether it's a 
problem or not is up to the platform maintainer(s). 

> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> Changes from v1:
> - Reword commit message for clarity (hopefully)
> - Drop unrelated change in qcom,msm8998-pinctrl.txt
> - CC DT
> ---
>  .../bindings/pinctrl/qcom,msm8998-pinctrl.txt |  5 +-

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/pinctrl/qcom/pinctrl-msm8998.c        | 76 +++++--------------
>  2 files changed, 20 insertions(+), 61 deletions(-)

  parent reply	other threads:[~2019-07-22 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  8:57 [PATCH v2] pinctrl: msm8998: Squash TSIF pins together Marc Gonzalez
2019-07-04 16:35 ` Bjorn Andersson
2019-07-18  9:30   ` Marc Gonzalez
2019-07-18 13:34     ` Bjorn Andersson
2019-07-22 23:53 ` Rob Herring [this message]
2019-07-29 21:30 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722235300.GA24879@bogus \
    --to=robh@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=jeffrey.l.hugo@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).