[PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap

linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
@ 2019-07-03 14:56 Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 2/4] pinctrl: cherryview: " Andy Shevchenko
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-03 14:56 UTC (permalink / raw)
  To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-baytrail.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index bfde1c710bd9..4fc4f9658484 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1582,12 +1582,10 @@ static int byt_set_soc_data(struct byt_gpio *vg,
 
 	for (i = 0; i < soc_data->ncommunities; i++) {
 		struct byt_community *comm = vg->communities_copy + i;
-		struct resource *mem_rc;
 
 		*comm = vg->soc_data->communities[i];
 
-		mem_rc = platform_get_resource(vg->pdev, IORESOURCE_MEM, 0);
-		comm->reg_base = devm_ioremap_resource(&vg->pdev->dev, mem_rc);
+		comm->reg_base = devm_platform_ioremap_resource(vg->pdev, 0);
 		if (IS_ERR(comm->reg_base))
 			return PTR_ERR(comm->reg_base);
 	}
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v1 2/4] pinctrl: cherryview: Use devm_platform_ioremap_resource()
  2019-07-03 14:56 [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource() Andy Shevchenko
@ 2019-07-03 14:56 ` Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 3/4] pinctrl: intel: " Andy Shevchenko
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-03 14:56 UTC (permalink / raw)
  To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index d0740714b3cb..6e7da421b6c9 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1689,7 +1689,6 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 {
 	struct chv_pinctrl *pctrl;
 	struct acpi_device *adev;
-	struct resource *res;
 	acpi_status status;
 	int ret, irq, i;
 
@@ -1717,8 +1716,7 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 	if (!pctrl->saved_pin_context)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	pctrl->regs = devm_ioremap_resource(&pdev->dev, res);
+	pctrl->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(pctrl->regs))
 		return PTR_ERR(pctrl->regs);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v1 3/4] pinctrl: intel: Use devm_platform_ioremap_resource()
  2019-07-03 14:56 [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource() Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 2/4] pinctrl: cherryview: " Andy Shevchenko
@ 2019-07-03 14:56 ` Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 4/4] pinctrl: merrifield: " Andy Shevchenko
  2019-07-03 16:36 ` [PATCH v1 1/4] pinctrl: baytrail: " Mika Westerberg
  3 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-03 14:56 UTC (permalink / raw)
  To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-intel.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 13e4d61f14a4..dc6ef88790ae 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1313,15 +1313,12 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
 
 	for (i = 0; i < pctrl->ncommunities; i++) {
 		struct intel_community *community = &pctrl->communities[i];
-		struct resource *res;
 		void __iomem *regs;
 		u32 padbar;
 
 		*community = pctrl->soc->communities[i];
 
-		res = platform_get_resource(pdev, IORESOURCE_MEM,
-					    community->barno);
-		regs = devm_ioremap_resource(&pdev->dev, res);
+		regs = devm_platform_ioremap_resource(pdev, community->barno);
 		if (IS_ERR(regs))
 			return PTR_ERR(regs);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v1 4/4] pinctrl: merrifield: Use devm_platform_ioremap_resource()
  2019-07-03 14:56 [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource() Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 2/4] pinctrl: cherryview: " Andy Shevchenko
  2019-07-03 14:56 ` [PATCH v1 3/4] pinctrl: intel: " Andy Shevchenko
@ 2019-07-03 14:56 ` Andy Shevchenko
  2019-07-03 16:36 ` [PATCH v1 1/4] pinctrl: baytrail: " Mika Westerberg
  3 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-03 14:56 UTC (permalink / raw)
  To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko

Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-merrifield.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-merrifield.c b/drivers/pinctrl/intel/pinctrl-merrifield.c
index 4b65e1296b8a..04ca8ae95df8 100644
--- a/drivers/pinctrl/intel/pinctrl-merrifield.c
+++ b/drivers/pinctrl/intel/pinctrl-merrifield.c
@@ -885,7 +885,6 @@ static int mrfld_pinctrl_probe(struct platform_device *pdev)
 {
 	struct mrfld_family *families;
 	struct mrfld_pinctrl *mp;
-	struct resource *mem;
 	void __iomem *regs;
 	size_t nfamilies;
 	unsigned int i;
@@ -897,8 +896,7 @@ static int mrfld_pinctrl_probe(struct platform_device *pdev)
 	mp->dev = &pdev->dev;
 	raw_spin_lock_init(&mp->lock);
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	regs = devm_ioremap_resource(&pdev->dev, mem);
+	regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(regs))
 		return PTR_ERR(regs);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
  2019-07-03 14:56 [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource() Andy Shevchenko
                   ` (2 preceding siblings ...)
  2019-07-03 14:56 ` [PATCH v1 4/4] pinctrl: merrifield: " Andy Shevchenko
@ 2019-07-03 16:36 ` Mika Westerberg
  2019-07-23 15:51   ` Andy Shevchenko
  3 siblings, 1 reply; 9+ messages in thread
From: Mika Westerberg @ 2019-07-03 16:36 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-gpio, Linus Walleij

On Wed, Jul 03, 2019 at 05:56:12PM +0300, Andy Shevchenko wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

For the whole series,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
  2019-07-03 16:36 ` [PATCH v1 1/4] pinctrl: baytrail: " Mika Westerberg
@ 2019-07-23 15:51   ` Andy Shevchenko
  2019-07-28 22:06     ` Linus Walleij
  0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-23 15:51 UTC (permalink / raw)
  To: Mika Westerberg; +Cc: linux-gpio, Linus Walleij

On Wed, Jul 03, 2019 at 07:36:30PM +0300, Mika Westerberg wrote:
> On Wed, Jul 03, 2019 at 05:56:12PM +0300, Andy Shevchenko wrote:
> > Use the new helper that wraps the calls to platform_get_resource()
> > and devm_ioremap_resource() together.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> For the whole series,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
  2019-07-23 15:51   ` Andy Shevchenko
@ 2019-07-28 22:06     ` Linus Walleij
  2019-07-29  9:37       ` Andy Shevchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2019-07-28 22:06 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Mika Westerberg, open list:GPIO SUBSYSTEM

On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Pushed to my review and testing queue, thanks!

I take it I can get a pull request with all the Intel pinctrl changes?
They all look good to me.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
  2019-07-28 22:06     ` Linus Walleij
@ 2019-07-29  9:37       ` Andy Shevchenko
  2019-07-29 21:25         ` Linus Walleij
  0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2019-07-29  9:37 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Mika Westerberg, open list:GPIO SUBSYSTEM

On Mon, Jul 29, 2019 at 12:06:52AM +0200, Linus Walleij wrote:
> On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Pushed to my review and testing queue, thanks!
> 
> I take it I can get a pull request with all the Intel pinctrl changes?
> They all look good to me.

Yes, we are collecting them, and GPIO as well.


-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
  2019-07-29  9:37       ` Andy Shevchenko
@ 2019-07-29 21:25         ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2019-07-29 21:25 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Mika Westerberg, open list:GPIO SUBSYSTEM

On Mon, Jul 29, 2019 at 11:37 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Jul 29, 2019 at 12:06:52AM +0200, Linus Walleij wrote:
> > On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > Pushed to my review and testing queue, thanks!
> >
> > I take it I can get a pull request with all the Intel pinctrl changes?
> > They all look good to me.
>
> Yes, we are collecting them, and GPIO as well.

Awesome, thanks a LOT!

Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-07-29 21:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-03 14:56 [PATCH v1 1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource() Andy Shevchenko
2019-07-03 14:56 ` [PATCH v1 2/4] pinctrl: cherryview: " Andy Shevchenko
2019-07-03 14:56 ` [PATCH v1 3/4] pinctrl: intel: " Andy Shevchenko
2019-07-03 14:56 ` [PATCH v1 4/4] pinctrl: merrifield: " Andy Shevchenko
2019-07-03 16:36 ` [PATCH v1 1/4] pinctrl: baytrail: " Mika Westerberg
2019-07-23 15:51   ` Andy Shevchenko
2019-07-28 22:06     ` Linus Walleij
2019-07-29  9:37       ` Andy Shevchenko
2019-07-29 21:25         ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).