linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 8/8] pinctrl: intel: Remove default Interrupt Status offset
Date: Tue, 23 Jul 2019 18:56:33 +0300	[thread overview]
Message-ID: <20190723155633.65232-8-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190723155633.65232-1-andriy.shevchenko@linux.intel.com>

Since some of the GPIO controllers use different Interrupt Status offset,
it make sense to provide it explicitly in the drivers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-intel.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 1e8018edde4d..3a945997b8eb 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -30,7 +30,6 @@
 #define REVID_MASK			GENMASK(31, 16)
 
 #define PADBAR				0x00c
-#define GPI_IS				0x100
 
 #define PADOWN_BITS			4
 #define PADOWN_SHIFT(p)			((p) % 8 * PADOWN_BITS)
@@ -1343,9 +1342,6 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
 		community->regs = regs;
 		community->pad_regs = regs + padbar;
 
-		if (!community->is_offset)
-			community->is_offset = GPI_IS;
-
 		ret = intel_pinctrl_add_padgroups(pctrl, community);
 		if (ret)
 			return ret;
-- 
2.20.1


  parent reply	other threads:[~2019-07-23 15:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 15:56 [PATCH v1 1/8] pinctrl: broxton: Provide Interrupt Status register offset Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 2/8] pinctrl: cannonlake: " Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 3/8] pinctrl: geminilake: " Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 4/8] pinctrl: icelake: " Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 5/8] pinctrl: sunrisepoint: " Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 6/8] pinctrl: denverton: " Andy Shevchenko
2019-07-23 15:56 ` [PATCH v1 7/8] pinctrl: lewisburg: " Andy Shevchenko
2019-07-23 15:56 ` Andy Shevchenko [this message]
2019-08-06 10:30 ` [PATCH v1 1/8] pinctrl: broxton: " Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723155633.65232-8-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).