* [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used
@ 2019-07-31 17:38 Ramon Fried
2019-08-01 8:10 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Ramon Fried @ 2019-07-31 17:38 UTC (permalink / raw)
To: bgolaszewski; +Cc: linus.walleij, linux-gpio, Ramon Fried
In case where the GPIOLINE_FLAG_KERNEL flag was set
and no consumer string is provided by the kernel,
the used column was still showing the pin as "unused"
Fix that by writing "kernel".
Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
---
v2:
* Restructure for clarity
* Print "kernel" if line is used by kernel.
* Update commit message
tools/gpioinfo.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/gpioinfo.c b/tools/gpioinfo.c
index bb17262..ba0327b 100644
--- a/tools/gpioinfo.c
+++ b/tools/gpioinfo.c
@@ -119,8 +119,12 @@ static void list_lines(struct gpiod_chip *chip)
: prinfo(&of, 12, "unnamed");
printf(" ");
- consumer ? prinfo(&of, 12, "\"%s\"", consumer)
- : prinfo(&of, 12, "unused");
+ if (!gpiod_line_is_used(line))
+ prinfo(&of, 12, "unused");
+ else
+ consumer ? prinfo(&of, 12, "\"%s\"", consumer)
+ : prinfo(&of, 12, "kernel");
+
printf(" ");
prinfo(&of, 8, "%s ", direction == GPIOD_LINE_DIRECTION_INPUT
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used
2019-07-31 17:38 [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used Ramon Fried
@ 2019-08-01 8:10 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-08-01 8:10 UTC (permalink / raw)
To: Ramon Fried; +Cc: Linus Walleij, linux-gpio
śr., 31 lip 2019 o 19:38 Ramon Fried <rfried.dev@gmail.com> napisał(a):
>
> In case where the GPIOLINE_FLAG_KERNEL flag was set
> and no consumer string is provided by the kernel,
> the used column was still showing the pin as "unused"
> Fix that by writing "kernel".
>
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
> ---
> v2:
> * Restructure for clarity
> * Print "kernel" if line is used by kernel.
> * Update commit message
>
> tools/gpioinfo.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/gpioinfo.c b/tools/gpioinfo.c
> index bb17262..ba0327b 100644
> --- a/tools/gpioinfo.c
> +++ b/tools/gpioinfo.c
> @@ -119,8 +119,12 @@ static void list_lines(struct gpiod_chip *chip)
> : prinfo(&of, 12, "unnamed");
> printf(" ");
>
> - consumer ? prinfo(&of, 12, "\"%s\"", consumer)
> - : prinfo(&of, 12, "unused");
> + if (!gpiod_line_is_used(line))
> + prinfo(&of, 12, "unused");
> + else
> + consumer ? prinfo(&of, 12, "\"%s\"", consumer)
> + : prinfo(&of, 12, "kernel");
> +
> printf(" ");
>
> prinfo(&of, 8, "%s ", direction == GPIOD_LINE_DIRECTION_INPUT
> --
> 2.22.0
>
Applied with indentation and alignment fixed.
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-01 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-31 17:38 [libgpiod] [PATCH v2] gpioinfo: mark kernel claimed lines as used Ramon Fried
2019-08-01 8:10 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).