linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers
Date: Fri, 16 Aug 2019 21:56:40 +0200	[thread overview]
Message-ID: <20190816195640.GD6886@kunai> (raw)
In-Reply-To: <205d0ef7-d487-006b-d104-88958f40e197@metux.net>

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]


(Found this mail in the offline draft folder of another laptop)

> So, then the current approach of using subsys_initcall() can't be
> changed easily, right now. But planned for the future (or at least
> not introducing new caes).

Yes.

> But: how does that conflict w/ just moving the existing redundant
> pieces into a helper macro ? The logic stays the same - just using
> a shorter notation. (assuming my patch isn't buggy ;-)).

It is not conflicting. My thinking is that such helpers, in general,
scale better and are less error prone. But there is nothing to scale
here.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2019-08-16 19:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 18:39 [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers Enrico Weigelt, metux IT consult
2019-06-17 18:39 ` [PATCH 2/3] drivers: gpio: pca953x: use subsys_i2c_driver() Enrico Weigelt, metux IT consult
2019-06-17 18:39 ` [PATCH 3/3] drivers: gpio: pcf857x: " Enrico Weigelt, metux IT consult
2019-06-21 21:17 ` [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers Wolfram Sang
2019-06-24  5:44   ` Enrico Weigelt, metux IT consult
2019-06-24  8:44     ` Wolfram Sang
2019-06-24  8:59       ` Enrico Weigelt, metux IT consult
2019-08-16 19:56         ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816195640.GD6886@kunai \
    --to=wsa@the-dreams.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=info@metux.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).