From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Alban Bedel <albeu@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 2/9] lib: devres: prepare devm_ioremap_resource() for more variants
Date: Thu, 29 Aug 2019 16:37:35 +0200 [thread overview]
Message-ID: <20190829143742.24726-3-brgl@bgdev.pl> (raw)
In-Reply-To: <20190829143742.24726-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
We want to add the nocache and write-combined variants of
devm_ioremap_resource(). Let's first implement __devm_ioremap_resource()
which takes an additional argument type. The types are the same as
for __devm_ioremap(). The existing devm_ioremap_resource() now simply
calls __devm_ioremap_resource() with regular DEVM_IOREMAP type.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
lib/devres.c | 47 +++++++++++++++++++++++++++--------------------
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/lib/devres.c b/lib/devres.c
index 6a0e9bd6524a..a14c727128c1 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -114,25 +114,9 @@ void devm_iounmap(struct device *dev, void __iomem *addr)
}
EXPORT_SYMBOL(devm_iounmap);
-/**
- * devm_ioremap_resource() - check, request region, and ioremap resource
- * @dev: generic device to handle the resource for
- * @res: resource to be handled
- *
- * Checks that a resource is a valid memory region, requests the memory
- * region and ioremaps it. All operations are managed and will be undone
- * on driver detach.
- *
- * Returns a pointer to the remapped memory or an ERR_PTR() encoded error code
- * on failure. Usage example:
- *
- * res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- * base = devm_ioremap_resource(&pdev->dev, res);
- * if (IS_ERR(base))
- * return PTR_ERR(base);
- */
-void __iomem *devm_ioremap_resource(struct device *dev,
- const struct resource *res)
+static void __iomem *
+__devm_ioremap_resource(struct device *dev, const struct resource *res,
+ enum devm_ioremap_type type)
{
resource_size_t size;
void __iomem *dest_ptr;
@@ -151,7 +135,7 @@ void __iomem *devm_ioremap_resource(struct device *dev,
return IOMEM_ERR_PTR(-EBUSY);
}
- dest_ptr = devm_ioremap(dev, res->start, size);
+ dest_ptr = __devm_ioremap(dev, res->start, size, type);
if (!dest_ptr) {
dev_err(dev, "ioremap failed for resource %pR\n", res);
devm_release_mem_region(dev, res->start, size);
@@ -160,6 +144,29 @@ void __iomem *devm_ioremap_resource(struct device *dev,
return dest_ptr;
}
+
+/**
+ * devm_ioremap_resource() - check, request region, and ioremap resource
+ * @dev: generic device to handle the resource for
+ * @res: resource to be handled
+ *
+ * Checks that a resource is a valid memory region, requests the memory
+ * region and ioremaps it. All operations are managed and will be undone
+ * on driver detach.
+ *
+ * Returns a pointer to the remapped memory or an ERR_PTR() encoded error code
+ * on failure. Usage example:
+ *
+ * res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ * base = devm_ioremap_resource(&pdev->dev, res);
+ * if (IS_ERR(base))
+ * return PTR_ERR(base);
+ */
+void __iomem *devm_ioremap_resource(struct device *dev,
+ const struct resource *res)
+{
+ return __devm_ioremap_resource(dev, res, DEVM_IOREMAP);
+}
EXPORT_SYMBOL(devm_ioremap_resource);
/*
--
2.21.0
next prev parent reply other threads:[~2019-08-29 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:37 [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 1/9] Documentation: devres: add missing entry for devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` Bartosz Golaszewski [this message]
2019-08-29 14:37 ` [PATCH 3/9] lib: devres: provide new variants for devm_ioremap_resource() Bartosz Golaszewski
2019-08-29 15:09 ` Arnd Bergmann
2019-08-29 14:37 ` [PATCH 4/9] drivers: provide new variants of devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 5/9] gpio: em: use devm_platform_ioremap_resource_nocache() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 6/9] gpio: ath79: " Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 7/9] gpio: htc-egpio: " Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 8/9] gpio: xgene: " Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 9/9] misc: sram: use devm_platform_ioremap_resource_wc() Bartosz Golaszewski
2019-08-29 14:48 ` [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource() Geert Uytterhoeven
2019-08-30 15:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829143742.24726-3-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=Julia.Lawall@lip6.fr \
--cc=albeu@free.fr \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).