From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DA4C49ED7 for ; Fri, 20 Sep 2019 14:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F7832086A for ; Fri, 20 Sep 2019 14:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387955AbfITOYr (ORCPT ); Fri, 20 Sep 2019 10:24:47 -0400 Received: from muru.com ([72.249.23.125]:34008 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387938AbfITOYr (ORCPT ); Fri, 20 Sep 2019 10:24:47 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B502E80AA; Fri, 20 Sep 2019 14:25:18 +0000 (UTC) Date: Fri, 20 Sep 2019 07:24:44 -0700 From: Tony Lindgren To: Colin King Cc: Linus Walleij , YueHaibing , Nishanth Menon , Tero Kristo , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call Message-ID: <20190920142444.GP5610@atomide.com> References: <20190920122030.14340-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920122030.14340-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org * Colin King [190920 12:21]: > From: Colin Ian King > > The call to pinctrl_count_index_with_args checks for a -EINVAL return > however this function calls pinctrl_get_list_and_count and this can > return -ENOENT. Rather than check for a specific error, fix this by > checking for any error return to catch the -ENOENT case. Acked-by: Tony Lindgren