From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6954AC4CEC4 for ; Mon, 23 Sep 2019 16:01:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F4CE20B7C for ; Mon, 23 Sep 2019 16:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HkZLp6T2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732783AbfIWQA5 (ORCPT ); Mon, 23 Sep 2019 12:00:57 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:49992 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387706AbfIWQA5 (ORCPT ); Mon, 23 Sep 2019 12:00:57 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 270F653B; Mon, 23 Sep 2019 18:00:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1569254455; bh=Etat8NN7YLvsW2f3sC337/iHi/6qZmsmzIordeWfKk0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HkZLp6T2S5QxbJRI7OaV54luhyvzV8n+O1mR5gtRTjuF6hnhK/kji0uJzF7LsONPJ iuYn0eUA3oYTT/3KqkHeTICg0gzqMTAho7VwH2/bxjlXlMB2MGtA5Z2ziIQCplolcU peP0LQ0N1BnqbCyXMyxbqkGL0PZNe+/YlxqQjCTE= Date: Mon, 23 Sep 2019 19:00:45 +0300 From: Laurent Pinchart To: Heikki Krogerus Cc: Dmitry Torokhov , Linus Walleij , Andy Shevchenko , Mika Westerberg , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 06/11] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Message-ID: <20190923160045.GE5056@pendragon.ideasonboard.com> References: <20190911075215.78047-1-dmitry.torokhov@gmail.com> <20190911075215.78047-7-dmitry.torokhov@gmail.com> <20190920231228.GH12672@pendragon.ideasonboard.com> <20190923150333.GD16243@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190923150333.GD16243@kuha.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Heikki, On Mon, Sep 23, 2019 at 06:03:33PM +0300, Heikki Krogerus wrote: > On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote: > > Hi Dmitry, > > > > (CC'ing Heikki as the original author of software nodes support) > > > > Thank you for the patch. > > > > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > > > s/bit/but/ > > > > > works with arbitrary firmware node. > > > > > > Signed-off-by: Dmitry Torokhov > > > > Reviewed-by: Laurent Pinchart > > > > On a side note, as I'm not very familiar with software nodes, I tried to > > see how they are to be used, and it seems they are completely > > undocumented :-( Heikki, is this something that could be fixed ? > > OK. I'll start writing API documentation for it. That's great, thanks ! I'll do my best to review it if you CC me. -- Regards, Laurent Pinchart