linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Ingo Molnar <mingo@redhat.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Tal Shorer <tal.shorer@gmail.com>
Subject: Re: [PATCH 2/2] tracing: drop handling of NOTRACE symbol
Date: Sat, 28 Sep 2019 19:11:22 -0400	[thread overview]
Message-ID: <20190928191122.0de5b604@oasis.local.home> (raw)
In-Reply-To: <20190824140426.4kflanpydbafsmve@pengutronix.de>

On Sat, 24 Aug 2019 16:04:26 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> Hello Linus and Steven,
> 
> On Mon, Apr 08, 2019 at 04:29:15PM +0200, Linus Walleij wrote:
> > On Mon, Apr 8, 2019 at 4:27 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >   
> > > On Mon, 8 Apr 2019 15:42:55 +0200
> > > Linus Walleij <linus.walleij@linaro.org> wrote:
> > >  
> > > > > That's fine for me, but I'm a bit surprised you did that without an ack
> > > > > from the tracing people?  
> > > >
> > > > oOOPS no I guess I shouldn't, haha I just didn't
> > > > look close enough, I thought for some reason it only
> > > > applied in the GPIO subsystem. I'll back this out.  
> > >
> > > No need to back it out.
> > >
> > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>  
> > 
> > OK applied to the GPIO tree.  
> 
> I just found this patch in one of my older topic branches and it still
> applies to current Linus (Torvald)'s master.
> 
> Given that the only user is gone since 5.2-rc1 (commit
> 12f2639038ef420fe796171ffb810b30d1ac0619)
> 
> For reference, here comes it again, slightly adapted to reality. (Use
> git am --scissors to apply.)

I have some reservations against this patch. Mainly being that I'm
starting to think that we should be able to compile out individual
systems of trace events. The number of trace events continues to grow,
and there are many that I don't care about. This could be use to make
it easy to add configs that keep various trace event systems from being
compiled into the kernel.

-- Steve


  parent reply	other threads:[~2019-09-28 23:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150713143459.09582cb9@gandalf.local.home>
     [not found] ` <1437068376-24617-1-git-send-email-tal.shorer@gmail.com>
     [not found]   ` <1437068376-24617-3-git-send-email-tal.shorer@gmail.com>
2015-07-17 18:36     ` [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Steven Rostedt
2015-07-18 10:12       ` Tal Shorer
     [not found]         ` <1438432079-11704-1-git-send-email-tal.shorer@gmail.com>
     [not found]           ` <1438432079-11704-4-git-send-email-tal.shorer@gmail.com>
2019-03-27 16:12             ` [Patch v3 " Uwe Kleine-König
2019-04-05 17:25               ` Linus Walleij
     [not found]                 ` <20190405194613.19578-1-u.kleine-koenig@pengutronix.de>
     [not found]                   ` <20190405194613.19578-2-u.kleine-koenig@pengutronix.de>
     [not found]                     ` <CACRpkda1xoUZGMCDWGSvA7MPxXC5qc3tp8UiZt+us19vppGpyw@mail.gmail.com>
     [not found]                       ` <20190408133506.xv3cwcqkqdobgz2r@pengutronix.de>
     [not found]                         ` <CACRpkdbYtsVLXC61jn_Gy_X33N4DBD9eumf3JNVCLemk0sGHzQ@mail.gmail.com>
     [not found]                           ` <20190408102744.66856bdb@gandalf.local.home>
     [not found]                             ` <CACRpkdax=n6hYfixSgsVaT2vPiZGdCC=tbQJrazzao946_M7yA@mail.gmail.com>
2019-08-24 14:04                               ` [PATCH 2/2] tracing: drop handling of NOTRACE symbol Uwe Kleine-König
2019-09-27 12:41                                 ` Linus Walleij
2019-09-28 20:45                                   ` Linus Walleij
2019-09-28 23:11                                 ` Steven Rostedt [this message]
2015-07-27 11:57       ` [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190928191122.0de5b604@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tal.shorer@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).