From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Federico Ricchiuto <fed.ricchiuto@gmail.com>
Subject: Re: [PATCH v1] pinctrl: intel: Allocate IRQ chip dynamic
Date: Tue, 1 Oct 2019 11:31:42 +0300 [thread overview]
Message-ID: <20191001083142.GA2714@lahna.fi.intel.com> (raw)
In-Reply-To: <20190916144751.21525-1-andriy.shevchenko@linux.intel.com>
On Mon, Sep 16, 2019 at 05:47:51PM +0300, Andy Shevchenko wrote:
> Keeping the IRQ chip definition static shares it with multiple instances of
> the GPIO chip in the system. This is bad and now we get this warning from
> GPIO library:
>
> "detected irqchip that is shared with multiple gpiochips: please fix the driver."
>
> Hence, move the IRQ chip definition from being driver static into the struct
> intel_pinctrl. So a unique IRQ chip is used for each GPIO chip instance.
>
> Fixes: ee1a6ca43dba ("Add Intel Broxton pin controller support")
> Depends-on: 5ff56b015e85 ("Disable GPIO pin interrupts in suspend")
> Reported-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>
> Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to intel.git/fixes, thanks!
prev parent reply other threads:[~2019-10-01 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 14:47 [PATCH v1] pinctrl: intel: Allocate IRQ chip dynamic Andy Shevchenko
[not found] ` <A0EC9DA6-CDF9-46A7-890B-8EE00D6A4563@getmailspring.com>
2019-09-16 15:47 ` Mika Westerberg
[not found] ` <660ECFA3-BF3C-4AC2-AF76-7AA7200CD96D@getmailspring.com>
2019-09-16 16:05 ` Mika Westerberg
2019-10-01 8:31 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001083142.GA2714@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fed.ricchiuto@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).