From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
robh+dt@kernel.org, mark.rutland@arm.com, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
f.fainelli@gmail.com, richard.laing@alliedtelesis.co.nz
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH 2/2] gpio: Add xgs-iproc driver
Date: Fri, 4 Oct 2019 14:25:25 +1300 [thread overview]
Message-ID: <20191004012525.26647-3-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20191004012525.26647-1-chris.packham@alliedtelesis.co.nz>
This driver supports the Chip Common A GPIO controller present on a
number of Broadcom switch ASICs with integrated SoCs. The controller is
similar to the pinctrl-nsp-gpio and pinctrl-iproc-gpio blocks but
different enough that a separate driver is required.
This has been ported from Broadcom's XLDK 5.0.3 retaining only the CCA
support (pinctrl-iproc-gpio covers CCB).
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/gpio/Kconfig | 9 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-xgs-iproc.c | 422 ++++++++++++++++++++++++++++++++++
3 files changed, 432 insertions(+)
create mode 100644 drivers/gpio/gpio-xgs-iproc.c
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 38e096e6925f..4b3c0f8397d7 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -156,6 +156,15 @@ config GPIO_BRCMSTB
help
Say yes here to enable GPIO support for Broadcom STB (BCM7XXX) SoCs.
+config GPIO_XGS_IPROC
+ tristate "BRCM XGS iProc GPIO support"
+ depends on OF_GPIO && (ARCH_BCM_IPROC || COMPILE_TEST)
+ select GPIO_GENERIC
+ select GPIOLIB_IRQCHIP
+ default ARCH_BCM_IPROC
+ help
+ Say yes here to enable GPIO support for Broadcom XGS iProc SoCs.
+
config GPIO_CADENCE
tristate "Cadence GPIO support"
depends on OF_GPIO
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index d2fd19c15bae..3783c3d43fbe 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -37,6 +37,7 @@ obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o
obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o
obj-$(CONFIG_GPIO_BD9571MWV) += gpio-bd9571mwv.o
obj-$(CONFIG_GPIO_BRCMSTB) += gpio-brcmstb.o
+obj-$(CONFIG_GPIO_XGS_IPROC) += gpio-xgs-iproc.o
obj-$(CONFIG_GPIO_BT8XX) += gpio-bt8xx.o
obj-$(CONFIG_GPIO_CADENCE) += gpio-cadence.o
obj-$(CONFIG_GPIO_CLPS711X) += gpio-clps711x.o
diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
new file mode 100644
index 000000000000..12656ca7b9d4
--- /dev/null
+++ b/drivers/gpio/gpio-xgs-iproc.c
@@ -0,0 +1,422 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2017 Broadcom Corporation
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/irq.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/ioport.h>
+#include <linux/of_device.h>
+#include <linux/of_address.h>
+#include <linux/of_gpio.h>
+
+#define CCA_INT_F_GPIOINT BIT(0)
+#define CCA_INT_STS 0x20
+#define CCA_INT_MASK 0x24
+
+#define GPIO_CCA_DIN 0x0
+#define GPIO_CCA_DOUT 0x4
+#define GPIO_CCA_OUT_EN 0x8
+#define GPIO_CCA_INT_LEVEL 0x10
+#define GPIO_CCA_INT_LEVEL_MASK 0x14
+#define GPIO_CCA_INT_EVENT 0x18
+#define GPIO_CCA_INT_EVENT_MASK 0x1C
+#define GPIO_CCA_INT_EDGE 0x24
+
+struct iproc_gpio_chip {
+ struct device *dev;
+ void __iomem *base;
+ void __iomem *intr;
+ struct gpio_chip gc;
+ struct irq_chip irqchip;
+ spinlock_t lock;
+ struct irq_domain *irq_domain;
+};
+
+static u32 iproc_gpio_readl(struct iproc_gpio_chip *chip, int reg)
+{
+ return readl(chip->base + reg);
+}
+
+static void iproc_gpio_writel(struct iproc_gpio_chip *chip, u32 val, int reg)
+{
+ writel(val, chip->base + reg);
+}
+
+/* returns the corresponding gpio register bit */
+static int iproc_irq_to_gpio(struct iproc_gpio_chip *chip, u32 irq)
+{
+ struct irq_data *data = irq_domain_get_irq_data(chip->irq_domain, irq);
+
+ return data->hwirq;
+}
+
+static void iproc_gpio_irq_ack(struct irq_data *d)
+{
+ u32 irq = d->irq;
+ struct iproc_gpio_chip *chip = irq_get_chip_data(irq);
+ int pin;
+ u32 irq_type, event_status = 0;
+
+ pin = iproc_irq_to_gpio(chip, d->irq);
+ irq_type = irq_get_trigger_type(irq);
+ if (irq_type & IRQ_TYPE_EDGE_BOTH) {
+ event_status |= BIT(pin);
+ iproc_gpio_writel(chip, event_status, GPIO_CCA_INT_EVENT);
+ }
+}
+
+static void iproc_gpio_irq_unmask(struct irq_data *d)
+{
+ u32 irq = d->irq;
+ struct iproc_gpio_chip *chip = irq_get_chip_data(irq);
+ int pin;
+ u32 int_mask, irq_type, event_mask;
+
+ pin = iproc_irq_to_gpio(chip, irq);
+ irq_type = irq_get_trigger_type(irq);
+ event_mask = iproc_gpio_readl(chip, GPIO_CCA_INT_EVENT_MASK);
+ int_mask = iproc_gpio_readl(chip, GPIO_CCA_INT_LEVEL_MASK);
+
+ if (irq_type & IRQ_TYPE_EDGE_BOTH) {
+ event_mask |= 1 << pin;
+ iproc_gpio_writel(chip, event_mask, GPIO_CCA_INT_EVENT_MASK);
+ } else {
+ int_mask |= 1 << pin;
+ iproc_gpio_writel(chip, int_mask, GPIO_CCA_INT_LEVEL_MASK);
+ }
+}
+
+static void iproc_gpio_irq_mask(struct irq_data *d)
+{
+ u32 irq = d->irq;
+ struct iproc_gpio_chip *chip = irq_get_chip_data(irq);
+ int pin;
+ u32 irq_type, int_mask, event_mask;
+
+ pin = iproc_irq_to_gpio(chip, irq);
+ irq_type = irq_get_trigger_type(irq);
+ event_mask = iproc_gpio_readl(chip, GPIO_CCA_INT_EVENT_MASK);
+ int_mask = iproc_gpio_readl(chip, GPIO_CCA_INT_LEVEL_MASK);
+
+ if (irq_type & IRQ_TYPE_EDGE_BOTH) {
+ event_mask &= ~BIT(pin);
+ iproc_gpio_writel(chip, event_mask, GPIO_CCA_INT_EVENT_MASK);
+ } else {
+ int_mask &= ~BIT(pin);
+ iproc_gpio_writel(chip, int_mask, GPIO_CCA_INT_LEVEL_MASK);
+ }
+}
+
+
+static int iproc_gpio_irq_set_type(struct irq_data *d, u32 type)
+{
+ u32 irq = d->irq;
+ struct iproc_gpio_chip *chip = irq_get_chip_data(irq);
+ int pin;
+ u32 event_pol, int_pol;
+
+ pin = iproc_irq_to_gpio(chip, irq);
+
+ switch (type & IRQ_TYPE_SENSE_MASK) {
+ case IRQ_TYPE_EDGE_RISING:
+ event_pol = iproc_gpio_readl(chip, GPIO_CCA_INT_EDGE);
+ event_pol &= ~BIT(pin);
+ iproc_gpio_writel(chip, event_pol, GPIO_CCA_INT_EDGE);
+ break;
+ case IRQ_TYPE_EDGE_FALLING:
+ event_pol = iproc_gpio_readl(chip, GPIO_CCA_INT_EDGE);
+ event_pol |= BIT(pin);
+ iproc_gpio_writel(chip, event_pol, GPIO_CCA_INT_EDGE);
+ break;
+ case IRQ_TYPE_LEVEL_HIGH:
+ int_pol = iproc_gpio_readl(chip, GPIO_CCA_INT_LEVEL);
+ int_pol &= ~BIT(pin);
+ iproc_gpio_writel(chip, int_pol, GPIO_CCA_INT_LEVEL);
+ break;
+ case IRQ_TYPE_LEVEL_LOW:
+ int_pol = iproc_gpio_readl(chip, GPIO_CCA_INT_LEVEL);
+ int_pol |= BIT(pin);
+ iproc_gpio_writel(chip, int_pol, GPIO_CCA_INT_LEVEL);
+ break;
+ default:
+ /* should not come here */
+ return -EINVAL;
+ }
+
+ if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
+ irq_set_handler_locked(irq_get_irq_data(irq), handle_level_irq);
+ else if (type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
+ irq_set_handler_locked(irq_get_irq_data(irq), handle_edge_irq);
+
+ return 0;
+}
+
+static irqreturn_t iproc_gpio_irq_handler(int irq, void *data)
+{
+ struct iproc_gpio_chip *chip = (struct iproc_gpio_chip *)data;
+ struct gpio_chip gc = chip->gc;
+ int bit;
+ unsigned long int_bits = 0;
+ u32 int_status;
+
+ /* go through the entire GPIOs and handle all interrupts */
+ int_status = readl(chip->intr + CCA_INT_STS);
+ if (int_status & CCA_INT_F_GPIOINT) {
+ u32 event, level;
+
+ /* Get level and edge interrupts */
+ event = readl(chip->base + GPIO_CCA_INT_EVENT_MASK);
+ event &= readl(chip->base + GPIO_CCA_INT_EVENT);
+ level = readl(chip->base + GPIO_CCA_DIN);
+ level ^= readl(chip->base + GPIO_CCA_INT_LEVEL);
+ level &= readl(chip->base + GPIO_CCA_INT_LEVEL_MASK);
+ int_bits = level | event;
+
+ for_each_set_bit(bit, &int_bits, gc.ngpio)
+ generic_handle_irq(
+ irq_linear_revmap(chip->irq_domain, bit));
+ }
+
+ return int_bits ? IRQ_HANDLED : IRQ_NONE;
+}
+
+static int iproc_gpiolib_input(struct gpio_chip *gc, u32 gpio)
+{
+ struct iproc_gpio_chip *chip = gpiochip_get_data(gc);
+ unsigned long flags;
+ u32 val;
+
+ spin_lock_irqsave(&chip->lock, flags);
+
+ val = iproc_gpio_readl(chip, GPIO_CCA_OUT_EN);
+ val &= ~BIT(gpio);
+ iproc_gpio_writel(chip, val, GPIO_CCA_OUT_EN);
+
+ spin_unlock_irqrestore(&chip->lock, flags);
+
+ return 0;
+}
+
+static int iproc_gpiolib_output(struct gpio_chip *gc, u32 gpio, int value)
+{
+ struct iproc_gpio_chip *chip = gpiochip_get_data(gc);
+ unsigned long flags, val;
+
+ spin_lock_irqsave(&chip->lock, flags);
+
+ val = iproc_gpio_readl(chip, GPIO_CCA_OUT_EN);
+ val |= BIT(gpio);
+ iproc_gpio_writel(chip, val, GPIO_CCA_OUT_EN);
+
+ spin_unlock_irqrestore(&chip->lock, flags);
+
+ return 0;
+}
+
+static void iproc_gpiolib_set(struct gpio_chip *gc, u32 gpio, int value)
+{
+ struct iproc_gpio_chip *chip = gpiochip_get_data(gc);
+ unsigned long flags, val;
+
+ spin_lock_irqsave(&chip->lock, flags);
+
+ val = iproc_gpio_readl(chip, GPIO_CCA_OUT_EN);
+ val &= BIT(gpio);
+
+ /* this function only applies to output pin */
+ if (!val)
+ return;
+
+ val = iproc_gpio_readl(chip, GPIO_CCA_DOUT);
+ if (value == 0)
+ /* Set the pin to zero */
+ val &= ~BIT(gpio);
+ else
+ /* Set the pin to 1 */
+ val |= BIT(gpio);
+
+ iproc_gpio_writel(chip, val, GPIO_CCA_DOUT);
+
+ spin_unlock_irqrestore(&chip->lock, flags);
+}
+
+static int iproc_gpiolib_get(struct gpio_chip *gc, u32 gpio)
+{
+ struct iproc_gpio_chip *chip = gpiochip_get_data(gc);
+ unsigned long flags;
+ u32 val, is_out;
+ /* GPIO register bit */
+
+ spin_lock_irqsave(&chip->lock, flags);
+
+ /* determine the GPIO pin direction */
+ is_out = iproc_gpio_readl(chip, GPIO_CCA_OUT_EN);
+ is_out &= BIT(gpio);
+
+ if (is_out)
+ val = iproc_gpio_readl(chip, GPIO_CCA_DOUT);
+ else
+ val = iproc_gpio_readl(chip, GPIO_CCA_DIN);
+
+ spin_unlock_irqrestore(&chip->lock, flags);
+
+ return !!(val & BIT(gpio));
+}
+
+static int iproc_gpiolib_to_irq(struct gpio_chip *gc, u32 offset)
+{
+ struct iproc_gpio_chip *chip = gpiochip_get_data(gc);
+
+ return irq_linear_revmap(chip->irq_domain, offset);
+}
+
+static int iproc_gpio_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct device_node *dn = pdev->dev.of_node;
+ struct iproc_gpio_chip *chip;
+ u32 num_gpios;
+ int irq, ret;
+
+ chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
+ if (!chip)
+ return -ENOMEM;
+
+ chip->dev = dev;
+ platform_set_drvdata(pdev, chip);
+
+ chip->gc.label = dev_name(dev);
+
+ chip->base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(chip->base))
+ return PTR_ERR(chip->base);
+
+ /* Get number of GPIO pin */
+ if (of_property_read_u32(dn, "ngpios", &num_gpios)) {
+ dev_err(dev, "missing ngpios DT property\n");
+ return -EINVAL;
+ }
+ chip->gc.ngpio = num_gpios;
+ chip->gc.parent = dev;
+ chip->gc.of_node = dn;
+ chip->gc.direction_input = iproc_gpiolib_input;
+ chip->gc.direction_output = iproc_gpiolib_output;
+ chip->gc.set = iproc_gpiolib_set;
+ chip->gc.get = iproc_gpiolib_get;
+ chip->gc.to_irq = iproc_gpiolib_to_irq;
+
+ ret = gpiochip_add_data(&chip->gc, chip);
+ if (ret) {
+ dev_err(dev, "unable to add GPIO chip\n");
+ return ret;
+ }
+
+ irq = platform_get_irq(pdev, 0);
+ if (irq > 0) {
+ u32 val, count;
+ struct irq_chip *irqc;
+
+ irqc = &chip->irqchip;
+ irqc->name = dev_name(dev);
+ irqc->irq_ack = iproc_gpio_irq_ack;
+ irqc->irq_mask = iproc_gpio_irq_mask;
+ irqc->irq_unmask = iproc_gpio_irq_unmask;
+ irqc->irq_set_type = iproc_gpio_irq_set_type;
+ irqc->irq_enable = iproc_gpio_irq_unmask;
+ irqc->irq_disable = iproc_gpio_irq_mask;
+
+ chip->intr = devm_platform_ioremap_resource(pdev, 1);
+ if (IS_ERR(chip->intr))
+ return PTR_ERR(chip->intr);
+
+ /* Create irq domain */
+ chip->irq_domain = irq_domain_add_linear(dn, num_gpios,
+ &irq_domain_simple_ops, chip);
+
+ if (!chip->irq_domain) {
+ dev_err(dev, "Couldn't allocate IRQ domain\n");
+ ret = -ENODEV;
+ goto err_irq_domain;
+ }
+
+ /* Map each gpio pin to an IRQ and set the handler */
+ for (count = 0; count < num_gpios; count++) {
+ int irq;
+
+ irq = irq_create_mapping(chip->irq_domain, count);
+ irq_set_chip_and_handler(irq, irqc, handle_simple_irq);
+ irq_set_chip_data(irq, chip);
+ }
+
+ /* Enable GPIO interrupts for CCA GPIO */
+ val = readl(chip->intr + CCA_INT_MASK);
+ val |= CCA_INT_F_GPIOINT;
+ writel(val, chip->intr + CCA_INT_MASK);
+
+ /* Install ISR for this GPIO controller */
+ ret = devm_request_irq(dev, irq, iproc_gpio_irq_handler,
+ IRQF_SHARED, chip->gc.label, chip);
+ if (ret) {
+ dev_err(dev, "Fail to request IRQ%d: %d\n", irq, ret);
+ goto err_irq_request;
+ }
+ }
+
+ return 0;
+
+err_irq_request:
+ irq_domain_remove(chip->irq_domain);
+ chip->irq_domain = NULL;
+
+err_irq_domain:
+ gpiochip_remove(&chip->gc);
+
+ return ret;
+}
+
+static int __exit iproc_gpio_remove(struct platform_device *pdev)
+{
+ struct iproc_gpio_chip *chip;
+
+ chip = platform_get_drvdata(pdev);
+ if (!chip)
+ return -ENODEV;
+
+ if (chip->intr) {
+ u32 val;
+
+ val = readl(chip->intr + CCA_INT_MASK);
+ val &= ~CCA_INT_F_GPIOINT;
+ writel(val, chip->intr + CCA_INT_MASK);
+ }
+
+ gpiochip_remove(&chip->gc);
+
+ return 0;
+}
+
+static const struct of_device_id bcm_iproc_gpio_of_match[] __initconst = {
+ { .compatible = "brcm,iproc-gpio-cca" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, bcm_iproc_gpio_of_match);
+
+static struct platform_driver bcm_iproc_gpio_driver = {
+ .driver = {
+ .name = "iproc-xgs-gpio",
+ .owner = THIS_MODULE,
+ .of_match_table = bcm_iproc_gpio_of_match,
+ },
+ .probe = iproc_gpio_probe,
+ .remove = iproc_gpio_remove,
+};
+
+module_platform_driver(bcm_iproc_gpio_driver);
+
+MODULE_DESCRIPTION("XGS IPROC GPIO driver");
+MODULE_LICENSE("GPL v2");
--
2.23.0
next prev parent reply other threads:[~2019-10-04 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 1:25 [PATCH 0/2] gpio: brcm: XGS iProc GPIO driver Chris Packham
2019-10-04 1:25 ` [PATCH 1/2] dt-bindings: gpio: brcm: Add bindings for xgs-iproc Chris Packham
2019-10-15 19:23 ` Rob Herring
2019-10-04 1:25 ` Chris Packham [this message]
2019-10-04 3:01 ` [PATCH 2/2] gpio: Add xgs-iproc driver kbuild test robot
2019-10-04 3:30 ` kbuild test robot
2019-10-11 7:43 ` Linus Walleij
2019-10-13 22:08 ` Chris Packham
2019-10-16 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004012525.26647-3-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard.laing@alliedtelesis.co.nz \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).