From: Sasha Levin <sashal@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-gpio@vger.kernel.org, stable@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kent Gibson <warthog618@gmail.com>
Subject: Re: [PATCH v5.3, v4.19] gpiolib: don't clear FLAG_IS_OUT when emulating open-drain/open-source
Date: Mon, 14 Oct 2019 19:38:20 -0400 [thread overview]
Message-ID: <20191014233820.GE31224@sasha-vm> (raw)
In-Reply-To: <20191014155435.13234-1-brgl@bgdev.pl>
On Mon, Oct 14, 2019 at 05:54:35PM +0200, Bartosz Golaszewski wrote:
>From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
>When emulating open-drain/open-source by not actively driving the output
>lines - we're simply changing their mode to input. This is wrong as it
>will then make it impossible to change the value of such line - it's now
>considered to actually be in input mode. If we want to still use the
>direction_input() callback for simplicity then we need to set FLAG_IS_OUT
>manually in gpiod_direction_output() and not clear it in
>gpio_set_open_drain_value_commit() and
>gpio_set_open_source_value_commit().
>
>Fixes: c663e5f56737 ("gpio: support native single-ended hardware drivers")
>Cc: stable@vger.kernel.org
>Reported-by: Kent Gibson <warthog618@gmail.com>
>Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>[Bartosz: backported to v5.3, v4.19]
>Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
I've queued this and the 4.14 patch, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2019-10-14 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 15:54 [PATCH v5.3, v4.19] gpiolib: don't clear FLAG_IS_OUT when emulating open-drain/open-source Bartosz Golaszewski
2019-10-14 23:38 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014233820.GE31224@sasha-vm \
--to=sashal@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).