From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40D7ECE58C for ; Tue, 15 Oct 2019 19:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C64E02083B for ; Tue, 15 Oct 2019 19:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571167415; bh=k1eU3BDbRSLgDcXHL7HWIl6vjNah5vedh/ki6vPY3cM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=y57GxVU0zOQad7KWQ6fGDppvDVBeDKOe0Wb1GRss/0lhEA2+1MKvzhtPIrzCeGyPG mVW8c9dcKXivrJDfZIELqiCcIzsQ2ESXHpB+mFFM/ouFPTtuquiYFfMFlX2q+BlAwm F2sAXJrVAhWpBspnGnWC+9lvsTZd4vd7WPTRy96I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731557AbfJOTXc (ORCPT ); Tue, 15 Oct 2019 15:23:32 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:32905 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730839AbfJOTXb (ORCPT ); Tue, 15 Oct 2019 15:23:31 -0400 Received: by mail-oi1-f194.google.com with SMTP id a15so17876583oic.0; Tue, 15 Oct 2019 12:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H0OMnipU3yZwO8kSIOH3gQiSnrV8gK6RMoDMYF6Q6mc=; b=P76q6HjJVfyBsuTyRZvIXyyAoEfg6B+n87n7DW931TXcv7DpE6ZqWtrXjOs9QYRsoN xLn131LipYDyL+tES1+MZjSTNOjAmxxMDY8tIWDhOKjB9CknyYdB5D4bAwtkglfY7/ha fC5A2eNri4XIxBOh5ydbaBbrctPxyT//AgQmOxt3C0cOODDU8QxW1P1QbLfXHcuz+QfL T2UMJcy/mfu1YUknO8hhG+p1nFg+ffeTHnF9sA6C8wWJ9D3I9/njNMTB4hxWyZQmuIdf O6d8gcKv/2Y7FA08edKX55RRH646IUol3NugFMqzYGP9pYhrSbuCjM6r6ZwofrF4ZoX2 hn/w== X-Gm-Message-State: APjAAAWZGdF6NMN2zswArNt28TFx09CJGt3d++fz2BBAd1dn4Mz+Nx1K dn0nJ5O7NhdeqO7Hf1fzfQ== X-Google-Smtp-Source: APXvYqzE/Pe9qiNzdDA7q6NFwpwrP4q0K1yle0GZw4+iqWkBcdbOEV1cxKDZyPI4BY1GtsDAdEQwBw== X-Received: by 2002:a54:4481:: with SMTP id v1mr141057oiv.152.1571167410301; Tue, 15 Oct 2019 12:23:30 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k34sm6865815otk.51.2019.10.15.12.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 12:23:29 -0700 (PDT) Date: Tue, 15 Oct 2019 14:23:28 -0500 From: Rob Herring To: Chris Packham Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, mark.rutland@arm.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, richard.laing@alliedtelesis.co.nz, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: gpio: brcm: Add bindings for xgs-iproc Message-ID: <20191015192328.GA26346@bogus> References: <20191004012525.26647-1-chris.packham@alliedtelesis.co.nz> <20191004012525.26647-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004012525.26647-2-chris.packham@alliedtelesis.co.nz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Oct 04, 2019 at 02:25:24PM +1300, Chris Packham wrote: > This GPIO controller is present on a number of Broadcom switch ASICs > with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio > blocks but different enough to require a separate driver. > > Signed-off-by: Chris Packham > --- > .../bindings/gpio/brcm,xgs-iproc.txt | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt Please make this a DT schema. > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt > new file mode 100644 > index 000000000000..328b844c82dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt > @@ -0,0 +1,41 @@ > +Broadcom XGS iProc GPIO controller > + > +This controller is the Chip Common A GPIO present on a number of Broadcom > +switch ASICs with integrated SoCs. > + > +Required properties: > +- compatible: > + Must be "brcm,iproc-gpio-cca" > + > +- reg: > + The first region defines the base I/O address containing > + the GPIO controller registers. The second region defines > + the I/O address containing the Chip Common A interrupt > + registers. > + > +Optional properties: > + > +- interrupts: > + The interrupt shared by all GPIO lines for this controller. > + > +- #interrupt-cells: > + Should be <2>. The first cell is the GPIO number, the second should specify > + flags. > + > + See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > + > +- interrupt-controller: > + Marks the device node as an interrupt controller > + > +Example: > + gpioa: gpio@18000060 { > + compatible = "brcm,iproc-gpio-cca"; > + #gpio-cells = <2>; Not documented... > + reg = <0x18000060 0x50>, > + <0x18000000 0x50>; > + ngpios = <12>; Not documented. > + gpio-controller; Not documented. > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = ; > + }; > -- > 2.23.0 >