linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/5] gpio: expose line bias flags to userspace
@ 2019-10-20 14:42 Kent Gibson
  2019-10-20 14:42 ` [PATCH v3 1/5] gpio: expose pull-up/pull-down line " Kent Gibson
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Kent Gibson @ 2019-10-20 14:42 UTC (permalink / raw)
  To: linux-gpio, bgolaszewski, linus.walleij, bamv2005; +Cc: drew, Kent Gibson

The major change from v2 is the change to three separate flags rather 
than encoding four possible values into a two bit field.

I expect more work is required.  While I was initially satisfied with the 
patch, I have noticed a few deficiencies that I'm uncertain on how to 
best resolve:

There is no sanity checking on bias flag combinations, they are passed 
through unaltered to the pinctrl driver.  I'd add sanity checks, but I'm 
unsure which combinations are invalid.

The setting of bias is performed by gpio_set_bias, which is hooked into 
gpiod_direction_input and gpiod_direction_output.  It extends the setting
of bias that was already present in gpiod_direction_input.
In keeping with the existing behaviour, the bias is set on a best-effort
basis - no error is returned to the user if an error is returned by the
pinctrl driver.  Returning an error makes sense to me, particularly for 
the uAPI, but that conflicts with the existing gpiod_direction_input
behaviour. So leave as best-effort, change gpiod_direction_input 
behaviour, or restructure to support both behaviours?

Also, the gpio_set_bias is hooked into gpiod_direction_output, which is 
fine for the uAPI, but perhaps it should be hooked into 
gpiod_direction_output_raw_commit?  Or the setting of direction 
and bias should be decoupled?

And now the actual blurb...

This series adds gross control of pull-up/pull-down to the GPIO uAPI.
Gross control means enabling and disabling of bias functionality,
not finer grained control such as setting biasing impedances.

The support allows both input and output lines to have any one of the
following biases applied as part of the line handle or event request:
 0. As Is - bias is left alone.  This is the default for ABI compatibility.
 1. Bias Disable - bias is explicitly disabled.
 2. Pull Down - pull-down bias is enabled.
 3. Pull Up - pull-up bias is enabled.

The biases are set via three flags, BIAS_DISABLE, BIAS_PULL_DOWN
and BIAS_PULL_UP.  These map directly to the similarly named 
pinctrl pin_config_param flags.
As Is corresponds to none of the flags being set.

The setting of biases on output lines may seem odd, but is to allow for
utilisation of internal pull-up/pull-down on open drain and open source
outputs, where supported in hardware.

Patches are against Bart's gpio/for-next branch[1].

The patch has been successfully tested against gpio-mockup, and 
on a Raspberry Pi, in both cases using the feature/pud branch of my Go 
gpiod library[2], as libgpiod still requires updating to match.

Patch 1 adds support to line handle requests.
Patch 2 adds support to line event requests and restricts bias settings 
to lines explicitly requested as inputs.
Patch 3 adds pull-up/down support to the gpio-mockup for uAPI testing.
Patch 4 adds support for disabling bias.
Patch 5 adds support for setting bias on output lines.

Drew Fustini (1):
  gpio: expose pull-up/pull-down line flags to userspace

Kent Gibson (4):
  gpiolib: add support for pull up/down to lineevent_create
  gpio: mockup: add set_config to support pull up/down
  gpiolib: add support for disabling line bias
  gpiolib: add support for bias output lines

 drivers/gpio/gpio-mockup.c | 94 ++++++++++++++++++++++++--------------
 drivers/gpio/gpiolib.c     | 65 +++++++++++++++++++++++---
 drivers/gpio/gpiolib.h     |  1 +
 include/uapi/linux/gpio.h  |  6 +++
 4 files changed, 126 insertions(+), 40 deletions(-)

-- 
2.23.0

[1] git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git
[2] https://github.com/warthog618/gpiod.git

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-20 14:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-20 14:42 [PATCH v3 0/5] gpio: expose line bias flags to userspace Kent Gibson
2019-10-20 14:42 ` [PATCH v3 1/5] gpio: expose pull-up/pull-down line " Kent Gibson
2019-10-20 14:42 ` [PATCH v3 2/5] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-10-20 14:42 ` [PATCH v3 3/5] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-10-20 14:42 ` [PATCH v3 4/5] gpiolib: add support for disabling line bias Kent Gibson
2019-10-20 14:42 ` [PATCH v3 5/5] gpiolib: add support for biasing output lines Kent Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).