From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Subject: Re: [PATCH] pinctrl: qcom: sc7180: Add missing tile info in SDC_QDSD_PINGROUP/UFS_RESET
Date: Mon, 21 Oct 2019 10:02:31 -0700 [thread overview]
Message-ID: <20191021170231.GK571@minitux> (raw)
In-Reply-To: <20191021141507.24066-1-rnayak@codeaurora.org>
On Mon 21 Oct 07:15 PDT 2019, Rajendra Nayak wrote:
> The SDC_QDSD_PINGROUP/UFS_RESET macros are missing the .tile info needed to
> calculate the right register offsets. Adding them here and also
> adjusting the offsets accordingly.
>
> Fixes: f2ae04c45b1a ("pinctrl: qcom: Add SC7180 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7180.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7180.c b/drivers/pinctrl/qcom/pinctrl-sc7180.c
> index 6399c8a2bc22..d6cfad7417b1 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7180.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7180.c
> @@ -77,6 +77,7 @@ enum {
> .intr_cfg_reg = 0, \
> .intr_status_reg = 0, \
> .intr_target_reg = 0, \
> + .tile = SOUTH, \
> .mux_bit = -1, \
> .pull_bit = pull, \
> .drv_bit = drv, \
> @@ -102,6 +103,7 @@ enum {
> .intr_cfg_reg = 0, \
> .intr_status_reg = 0, \
> .intr_target_reg = 0, \
> + .tile = SOUTH, \
> .mux_bit = -1, \
> .pull_bit = 3, \
> .drv_bit = 0, \
> @@ -1087,14 +1089,14 @@ static const struct msm_pingroup sc7180_groups[] = {
> [116] = PINGROUP(116, WEST, qup04, qup04, _, _, _, _, _, _, _),
> [117] = PINGROUP(117, WEST, dp_hot, _, _, _, _, _, _, _, _),
> [118] = PINGROUP(118, WEST, _, _, _, _, _, _, _, _, _),
> - [119] = UFS_RESET(ufs_reset, 0x97f000),
> - [120] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x97a000, 15, 0),
> - [121] = SDC_QDSD_PINGROUP(sdc1_clk, 0x97a000, 13, 6),
> - [122] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x97a000, 11, 3),
> - [123] = SDC_QDSD_PINGROUP(sdc1_data, 0x97a000, 9, 0),
> - [124] = SDC_QDSD_PINGROUP(sdc2_clk, 0x97b000, 14, 6),
> - [125] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x97b000, 11, 3),
> - [126] = SDC_QDSD_PINGROUP(sdc2_data, 0x97b000, 9, 0),
> + [119] = UFS_RESET(ufs_reset, 0x7f000),
> + [120] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x7a000, 15, 0),
PS. There's no drive-strength control of the rclk and I presume that's
why this is just specified as 0. It would be good if pinctrl-msm was
improved to be able to handle pins with bias, but no drive-strength
control and then this updated.
But we should merge this patch as is.
Regards,
Bjorn
> + [121] = SDC_QDSD_PINGROUP(sdc1_clk, 0x7a000, 13, 6),
> + [122] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x7a000, 11, 3),
> + [123] = SDC_QDSD_PINGROUP(sdc1_data, 0x7a000, 9, 0),
> + [124] = SDC_QDSD_PINGROUP(sdc2_clk, 0x7b000, 14, 6),
> + [125] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x7b000, 11, 3),
> + [126] = SDC_QDSD_PINGROUP(sdc2_data, 0x7b000, 9, 0),
> };
>
> static const struct msm_pinctrl_soc_data sc7180_pinctrl = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2019-10-21 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:15 [PATCH] pinctrl: qcom: sc7180: Add missing tile info in SDC_QDSD_PINGROUP/UFS_RESET Rajendra Nayak
2019-10-21 17:02 ` Bjorn Andersson [this message]
2019-11-04 15:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021170231.GK571@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).