* [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module
@ 2019-10-23 12:21 Matti Vaittinen
2019-10-23 14:49 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Matti Vaittinen @ 2019-10-23 12:21 UTC (permalink / raw)
To: matti.vaittinen, mazziesaccount
Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel
The bd70528 GPIO driver is probed by MFD driver. Add MODULE_ALIAS
in order to allow udev to load the module when MFD sub-device cell
for GPIO is added.
Fixes: 18bc64b3aebfa ("gpio: Initial support for ROHM bd70528 GPIO block")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
I'm not really sure if this is a bug-fix or feature but I guess the
Fixes tag won't harm, right?
drivers/gpio/gpio-bd70528.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c
index fd85605d2dab..8123260a92a2 100644
--- a/drivers/gpio/gpio-bd70528.c
+++ b/drivers/gpio/gpio-bd70528.c
@@ -230,3 +230,4 @@ module_platform_driver(bd70528_gpio);
MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>");
MODULE_DESCRIPTION("BD70528 voltage regulator driver");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:bd70528-gpio");
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module
2019-10-23 12:21 [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module Matti Vaittinen
@ 2019-10-23 14:49 ` Bartosz Golaszewski
2019-10-29 13:34 ` Vaittinen, Matti
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-10-23 14:49 UTC (permalink / raw)
To: Matti Vaittinen; +Cc: Matti Vaittinen, Linus Walleij, linux-gpio, LKML
śr., 23 paź 2019 o 14:22 Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> napisał(a):
>
> The bd70528 GPIO driver is probed by MFD driver. Add MODULE_ALIAS
> in order to allow udev to load the module when MFD sub-device cell
> for GPIO is added.
>
> Fixes: 18bc64b3aebfa ("gpio: Initial support for ROHM bd70528 GPIO block")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> I'm not really sure if this is a bug-fix or feature but I guess the
> Fixes tag won't harm, right?
It's definitely a feature, not a bug-fix. I applied it to for-next but
dropped the tag.
Bart
>
> drivers/gpio/gpio-bd70528.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c
> index fd85605d2dab..8123260a92a2 100644
> --- a/drivers/gpio/gpio-bd70528.c
> +++ b/drivers/gpio/gpio-bd70528.c
> @@ -230,3 +230,4 @@ module_platform_driver(bd70528_gpio);
> MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>");
> MODULE_DESCRIPTION("BD70528 voltage regulator driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:bd70528-gpio");
> --
> 2.21.0
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module
2019-10-23 14:49 ` Bartosz Golaszewski
@ 2019-10-29 13:34 ` Vaittinen, Matti
0 siblings, 0 replies; 3+ messages in thread
From: Vaittinen, Matti @ 2019-10-29 13:34 UTC (permalink / raw)
To: bgolaszewski@baylibre.com
Cc: mazziesaccount@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org
On Wed, 2019-10-23 at 16:49 +0200, Bartosz Golaszewski wrote:
> śr., 23 paź 2019 o 14:22 Matti Vaittinen
>
> > I'm not really sure if this is a bug-fix or feature but I guess the
> > Fixes tag won't harm, right?
>
> It's definitely a feature, not a bug-fix. I applied it to for-next
> but
> dropped the tag.
Thanks!
--Matti
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 12:21 [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module Matti Vaittinen
2019-10-23 14:49 ` Bartosz Golaszewski
2019-10-29 13:34 ` Vaittinen, Matti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).