From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5A2CA9EBC for ; Fri, 25 Oct 2019 10:01:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2027E20867 for ; Fri, 25 Oct 2019 10:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439175AbfJYKBB (ORCPT ); Fri, 25 Oct 2019 06:01:01 -0400 Received: from mga04.intel.com ([192.55.52.120]:51143 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438786AbfJYKBB (ORCPT ); Fri, 25 Oct 2019 06:01:01 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 03:01:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,228,1569308400"; d="scan'208";a="210346255" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 25 Oct 2019 03:00:59 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 25 Oct 2019 13:00:58 +0300 Date: Fri, 25 Oct 2019 13:00:58 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1] pinctrl: cherryview: Allocate IRQ chip dynamic Message-ID: <20191025100058.GK2593@lahna.fi.intel.com> References: <20191024133441.76222-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024133441.76222-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Oct 24, 2019 at 04:34:41PM +0300, Andy Shevchenko wrote: > Keeping the IRQ chip definition static shares it with multiple instances > of the GPIO chip in the system. This is bad and now we get this warning > from GPIO library: > > "detected irqchip that is shared with multiple gpiochips: please fix the driver." > > Hence, move the IRQ chip definition from being driver static into the struct > intel_pinctrl. So a unique IRQ chip is used for each GPIO chip instance. > > This patch is heavily based on the attachment to the bug by Christoph Marz. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=202543 > Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support") > Depends-on: 83b9dc11312f ("pinctrl: cherryview: Associate IRQ descriptors to irqdomain") > Signed-off-by: Andy Shevchenko Applied to fixes, thanks!