From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com,
linus.walleij@linaro.org, bamv2005@gmail.com
Cc: drew@pdp7.com, Kent Gibson <warthog618@gmail.com>
Subject: [PATCH v4 5/5] gpiolib: add support for biasing output lines
Date: Mon, 28 Oct 2019 15:37:13 +0800 [thread overview]
Message-ID: <20191028073713.25664-6-warthog618@gmail.com> (raw)
In-Reply-To: <20191028073713.25664-1-warthog618@gmail.com>
Allow pull up/down bias to be set on output lines.
Use case is for open source or open drain applications where
internal pull up/down may conflict with external biasing.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
drivers/gpio/gpiolib.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 177d25e19758..56b2814b843e 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -555,8 +555,9 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
(lflags & GPIOHANDLE_REQUEST_OPEN_SOURCE)))
return -EINVAL;
- /* Bias flags only allowed for input mode. */
- if (!(lflags & GPIOHANDLE_REQUEST_INPUT) &&
+ /* Bias flags only allowed for input or output mode. */
+ if (!((lflags & GPIOHANDLE_REQUEST_INPUT) ||
+ (lflags & GPIOHANDLE_REQUEST_OUTPUT)) &&
((lflags & GPIOHANDLE_REQUEST_BIAS_DISABLE) ||
(lflags & GPIOHANDLE_REQUEST_BIAS_PULL_UP) ||
(lflags & GPIOHANDLE_REQUEST_BIAS_PULL_DOWN)))
@@ -3148,6 +3149,7 @@ int gpiod_direction_output(struct gpio_desc *desc, int value)
}
set_output_value:
+ gpio_set_bias(gc, desc);
return gpiod_direction_output_raw_commit(desc, value);
}
EXPORT_SYMBOL_GPL(gpiod_direction_output);
--
2.23.0
next prev parent reply other threads:[~2019-10-28 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 7:37 [PATCH v4 0/5] gpio: expose line bias flags to userspace Kent Gibson
2019-10-28 7:37 ` [PATCH v4 1/5] gpio: expose pull-up/pull-down line " Kent Gibson
2019-10-28 7:37 ` [PATCH v4 2/5] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-10-31 7:11 ` Bartosz Golaszewski
2019-10-31 7:24 ` Kent Gibson
2019-10-28 7:37 ` [PATCH v4 3/5] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-10-28 7:37 ` [PATCH v4 4/5] gpiolib: add support for disabling line bias Kent Gibson
2019-10-28 7:37 ` Kent Gibson [this message]
2019-10-31 7:10 ` [PATCH v4 0/5] gpio: expose line bias flags to userspace Bartosz Golaszewski
2019-11-04 0:26 ` Linus Walleij
2019-11-04 1:07 ` Kent Gibson
2019-11-04 10:14 ` Bartosz Golaszewski
2019-11-04 11:11 ` Kent Gibson
2019-11-04 11:48 ` Bartosz Golaszewski
2019-11-04 14:22 ` Kent Gibson
2019-11-04 15:20 ` Bartosz Golaszewski
2019-11-04 15:35 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028073713.25664-6-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=bamv2005@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=drew@pdp7.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).