From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B59CA9EC7 for ; Sat, 2 Nov 2019 10:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0BE721726 for ; Sat, 2 Nov 2019 10:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfKBKxb (ORCPT ); Sat, 2 Nov 2019 06:53:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:44340 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbfKBKxb (ORCPT ); Sat, 2 Nov 2019 06:53:31 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2019 03:53:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,259,1569308400"; d="scan'208";a="191251212" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 02 Nov 2019 03:53:27 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iQr27-00008s-7J; Sat, 02 Nov 2019 12:53:27 +0200 Date: Sat, 2 Nov 2019 12:53:27 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Linus Walleij , Hans de Goede , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski Subject: Re: [PATCH] gpio/pinctrl: Add pin ranges before gpiochip Message-ID: <20191102105327.GE32742@smile.fi.intel.com> References: <20191030144940.21133-1-linus.walleij@linaro.org> <0e8c15d9-c805-c1ee-f8f0-528866c7ac1c@redhat.com> <9d21b3fe-852b-a430-4e71-af0742edcd9b@redhat.com> <20191030161041.GI2593@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030161041.GI2593@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Oct 30, 2019 at 06:10:41PM +0200, Mika Westerberg wrote: > On Wed, Oct 30, 2019 at 05:04:21PM +0100, Linus Walleij wrote: > > On Wed, Oct 30, 2019 at 5:01 PM Hans de Goede wrote: > > > > > For 5.4 we should probably revert > > > "gpio: merrifield: Pass irqchip when adding gpiochip" > > > and the fixes added on top of it, since AFAICT _AEI handling > > > will be broken on merrifield after this change too. > > > > > > So I suggest that we revert the following commits (in revert order): > > > > > > 4c87540940cbc7ddbe9674087919c605fd5c2ef1 "gpio: merrifield: Move hardware initialization to callback" > > > 6658f87f219427ee776c498e07c878eb5cad1be2 "gpio: merrifield: Restore use of irq_base" > > > 8f86a5b4ad679e4836733b47414226074eee4e4d "gpio: merrifield: Pass irqchip when adding gpiochip" > > > > > > That seems like the safest thing to do at this point in the cycle. > > > > OK are the Intel people OK with this? > > I'm fine but I'll leave this to Andy since that's his stuff. Ack. -- With Best Regards, Andy Shevchenko