From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F2EC49EAA for ; Tue, 5 Nov 2019 09:02:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A47EC20663 for ; Tue, 5 Nov 2019 09:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730499AbfKEJCC convert rfc822-to-8bit (ORCPT ); Tue, 5 Nov 2019 04:02:02 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:55211 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbfKEJCC (ORCPT ); Tue, 5 Nov 2019 04:02:02 -0500 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5CE50200012; Tue, 5 Nov 2019 09:01:58 +0000 (UTC) Date: Tue, 5 Nov 2019 10:01:57 +0100 From: Miquel Raynal To: Andy Shevchenko Cc: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Bartosz Golaszewski , Linus Walleij , Thierry Reding , "open list:GPIO SUBSYSTEM" , linux-pwm@vger.kernel.org, Linux Kernel Mailing List , Thomas Petazzoni , Sascha Hauer Subject: Re: [PATCH] gpio: pca953x: Add Maxim MAX7313 PWM support Message-ID: <20191105100157.2b6eb22b@xps13> In-Reply-To: References: <20191014124803.13661-1-miquel.raynal@bootlin.com> <20191015163055.0d8f44e5@xps13> <20191104161103.64995b8a@xps13> <20191104203346.epdbzflnynh2gf3z@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Uwe, Andy Shevchenko wrote on Tue, 5 Nov 2019 09:06:37 +0200: > On Mon, Nov 4, 2019 at 10:33 PM Uwe Kleine-König > wrote: > > On Mon, Nov 04, 2019 at 04:32:23PM +0100, Bartosz Golaszewski wrote: > > > pon., 4 lis 2019 o 16:11 Miquel Raynal napisał(a): > > > > Andy Shevchenko wrote on Tue, 15 Oct 2019 > > > > 17:55:33 +0300: > > > > > > > > > Or other way around. PWM registers GPIO (which actually I prefer since > > > > > we have PCA9685 case where PWM provides GPIO functionality, though via > > > > > different means) > > > While it's not nice to have a driver that provides two different devices > > (here: gpio controller and pwm controller) similar things are not > > unseen. And for example the splitting of watchdog > > (drivers/watchdog/stmp3xxx_rtc_wdt.c) and rtc > > (drivers/rtc/rtc-stmp3xxx.c) of the device in the mx28 is more trouble > > than worth. > > > > So I'd vote for putting it in a single file that lives where the > > bigger/more complex part fits to. So assuming that's the GPIO part (as > > the driver supports several variants and not all of them have a PWM > > function if I'm not mistaken) having it in drivers/gpio is fine for me. > > For me it sounds more likely that PWM is a *pin function* of a pin > controller and actually this GPIO driver should be a pin controller > with corresponding function(s). > Ok, thanks for the input, I will address Thierry's comments and re-submit as a single file (same shape as in v1). Kind regards, Miquèl