From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod] [PATCH 06/19] bindings: cxx: initialise bitset with integer instead of string
Date: Fri, 15 Nov 2019 22:43:42 +0800 [thread overview]
Message-ID: <20191115144355.975-7-warthog618@gmail.com> (raw)
In-Reply-To: <20191115144355.975-1-warthog618@gmail.com>
Initialising bitsets with string is inefficient and confusing.
Initialise them with the corresponding int instead.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
bindings/cxx/line_bulk.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bindings/cxx/line_bulk.cpp b/bindings/cxx/line_bulk.cpp
index 8369930..c708c8b 100644
--- a/bindings/cxx/line_bulk.cpp
+++ b/bindings/cxx/line_bulk.cpp
@@ -11,9 +11,9 @@
namespace gpiod {
-const ::std::bitset<32> line_request::FLAG_ACTIVE_LOW("001");
-const ::std::bitset<32> line_request::FLAG_OPEN_SOURCE("010");
-const ::std::bitset<32> line_request::FLAG_OPEN_DRAIN("100");
+const ::std::bitset<32> line_request::FLAG_ACTIVE_LOW(GPIOD_BIT(0));
+const ::std::bitset<32> line_request::FLAG_OPEN_SOURCE(GPIOD_BIT(1));
+const ::std::bitset<32> line_request::FLAG_OPEN_DRAIN(GPIOD_BIT(2));
namespace {
--
2.24.0
next prev parent reply other threads:[~2019-11-15 14:44 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 14:43 [libgpiod] [PATCH 00/19] Add support for bias flags and SET_CONFIG Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 01/19] core: move request flag to handle flag conversion into a separate function Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 02/19] API: add support for bias flags Kent Gibson
2019-11-18 13:51 ` Bartosz Golaszewski
2019-11-18 14:12 ` Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 03/19] core: fix misspelling of parameter Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 04/19] tests: add tests for bias flags Kent Gibson
2019-11-18 13:51 ` Bartosz Golaszewski
2019-11-18 14:14 ` Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 05/19] bindings: cxx: drop noexcept from direction and active_state Kent Gibson
2019-11-15 14:43 ` Kent Gibson [this message]
2019-11-18 13:51 ` [libgpiod] [PATCH 06/19] bindings: cxx: initialise bitset with integer instead of string Bartosz Golaszewski
2019-11-18 14:17 ` Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 07/19] bindings: cxx: add support for bias flags Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 08/19] bindings: cxx: tests: add tests " Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 09/19] bindings: python: add support " Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 10/19] bindings: python: tests: add tests " Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 11/19] API: add support for SET_CONFIG Kent Gibson
2019-11-18 13:52 ` Bartosz Golaszewski
2019-11-18 14:48 ` Kent Gibson
2019-11-19 15:52 ` Kent Gibson
2019-11-20 11:00 ` Bartosz Golaszewski
2019-11-20 13:58 ` Kent Gibson
2019-11-20 14:08 ` Bartosz Golaszewski
2019-11-20 14:13 ` Kent Gibson
2019-11-20 14:18 ` Bartosz Golaszewski
2019-11-20 14:36 ` Kent Gibson
2019-11-20 15:18 ` Bartosz Golaszewski
2019-11-21 0:34 ` Kent Gibson
2019-11-21 7:13 ` Bartosz Golaszewski
2019-11-21 7:46 ` Kent Gibson
2019-11-21 8:46 ` Bartosz Golaszewski
2019-11-21 9:30 ` Kent Gibson
2019-11-21 10:03 ` Bartosz Golaszewski
2019-11-21 10:18 ` Kent Gibson
2019-11-21 10:27 ` Bartosz Golaszewski
2019-11-21 10:31 ` Bartosz Golaszewski
2019-11-21 11:07 ` Kent Gibson
2019-11-21 15:22 ` Bartosz Golaszewski
2019-11-21 10:59 ` Kent Gibson
2019-11-21 15:20 ` Bartosz Golaszewski
2019-11-15 14:43 ` [libgpiod] [PATCH 12/19] tests: add tests " Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 13/19] core: allow gpiod_line_set_value_bulk to accept null values Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 14/19] bindings: cxx: add support for SET_CONFIG Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 15/19] bindings: cxx: tests: add tests for SET_CONFIG methods Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 16/19] bindings: python: add support for SET_CONFIG Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 17/19] bindings: python: tests: add tests for SET_CONFIG methods Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 18/19] tools: add support for bias flags Kent Gibson
2019-11-16 15:40 ` Kent Gibson
2019-11-17 12:18 ` Bartosz Golaszewski
2019-11-17 12:28 ` Kent Gibson
2019-11-17 13:12 ` Kent Gibson
2019-11-15 14:43 ` [libgpiod] [PATCH 19/19] treewide: change "correspond with" to "correspond to" Kent Gibson
2019-11-18 13:52 ` Bartosz Golaszewski
2019-11-18 15:01 ` Kent Gibson
2019-11-18 13:50 ` [libgpiod] [PATCH 00/19] Add support for bias flags and SET_CONFIG Bartosz Golaszewski
2019-11-18 14:09 ` Kent Gibson
2019-11-18 14:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115144355.975-7-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).