From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: make 'm_voc_groups' static
Date: Wed, 18 Dec 2019 11:33:09 -0800 [thread overview]
Message-ID: <20191218193309.GW36595@minitux> (raw)
In-Reply-To: <20191218102804.2487374-1-ben.dooks@codethink.co.uk>
On Wed 18 Dec 02:28 PST 2019, Ben Dooks (Codethink) wrote:
> The m_voc_groups is not declared outside of the
> driver, so make it static to avoid the following
> sparse wanrning:
>
> drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> index e1259ce27396..183f0b2d9f8e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> @@ -589,7 +589,7 @@ static const char * const blsp_uart5_groups[] = {
> static const char * const qdss_traceclk_a_groups[] = {
> "gpio46",
> };
> -const char * const m_voc_groups[] = {
> +static const char * const m_voc_groups[] = {
> "gpio123", "gpio124",
> };
> static const char * const blsp_i2c5_groups[] = {
> --
> 2.24.0
>
next prev parent reply other threads:[~2019-12-18 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 10:28 [PATCH] pinctrl: qcom: make 'm_voc_groups' static Ben Dooks (Codethink)
2019-12-18 19:33 ` Bjorn Andersson [this message]
2020-01-07 9:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218193309.GW36595@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).