* [PATCH] pinctrl: qcom: make 'm_voc_groups' static
@ 2019-12-18 10:28 Ben Dooks (Codethink)
2019-12-18 19:33 ` Bjorn Andersson
2020-01-07 9:40 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-18 10:28 UTC (permalink / raw)
To: ben.dooks
Cc: Andy Gross, Bjorn Andersson, Linus Walleij, linux-arm-msm,
linux-gpio
The m_voc_groups is not declared outside of the
driver, so make it static to avoid the following
sparse wanrning:
drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
index e1259ce27396..183f0b2d9f8e 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
@@ -589,7 +589,7 @@ static const char * const blsp_uart5_groups[] = {
static const char * const qdss_traceclk_a_groups[] = {
"gpio46",
};
-const char * const m_voc_groups[] = {
+static const char * const m_voc_groups[] = {
"gpio123", "gpio124",
};
static const char * const blsp_i2c5_groups[] = {
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: make 'm_voc_groups' static
2019-12-18 10:28 [PATCH] pinctrl: qcom: make 'm_voc_groups' static Ben Dooks (Codethink)
@ 2019-12-18 19:33 ` Bjorn Andersson
2020-01-07 9:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2019-12-18 19:33 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: Andy Gross, Linus Walleij, linux-arm-msm, linux-gpio
On Wed 18 Dec 02:28 PST 2019, Ben Dooks (Codethink) wrote:
> The m_voc_groups is not declared outside of the
> driver, so make it static to avoid the following
> sparse wanrning:
>
> drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/pinctrl/qcom/pinctrl-msm8976.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> index e1259ce27396..183f0b2d9f8e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> @@ -589,7 +589,7 @@ static const char * const blsp_uart5_groups[] = {
> static const char * const qdss_traceclk_a_groups[] = {
> "gpio46",
> };
> -const char * const m_voc_groups[] = {
> +static const char * const m_voc_groups[] = {
> "gpio123", "gpio124",
> };
> static const char * const blsp_i2c5_groups[] = {
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: make 'm_voc_groups' static
2019-12-18 10:28 [PATCH] pinctrl: qcom: make 'm_voc_groups' static Ben Dooks (Codethink)
2019-12-18 19:33 ` Bjorn Andersson
@ 2020-01-07 9:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-01-07 9:40 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: Andy Gross, Bjorn Andersson, MSM, open list:GPIO SUBSYSTEM
On Wed, Dec 18, 2019 at 11:30 AM Ben Dooks (Codethink)
<ben.dooks@codethink.co.uk> wrote:
> The m_voc_groups is not declared outside of the
> driver, so make it static to avoid the following
> sparse wanrning:
>
> drivers/pinctrl/qcom/pinctrl-msm8976.c:592:12: warning: symbol 'm_voc_groups' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Patch applied with Björn's ACK!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-07 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 10:28 [PATCH] pinctrl: qcom: make 'm_voc_groups' static Ben Dooks (Codethink)
2019-12-18 19:33 ` Bjorn Andersson
2020-01-07 9:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).