Re: [PATCH v7 11/12] leds: Add common LED binding parsing support to LED class/core

Vaittinen, Matti
2019-12-27T11:51:20Z

On Sat, 2019-12-21 at 20:37 +0100, Pavel Machek wrote:
> Hi!
>
> > Qucik grep for 'for_each' or 'linux,default-trigger' or
>
> quick.
>
> > If init_data is goven but no starting point for node lookup - then
>
> is given.
>
> > (parent) device's own DT node is used. If no led-compatible is
> > given,
> > then of_match is searched for. If neither led-compatible not
> > of_match
>
> nor of_match.
>
> > is given then device's own node or passed starting point are used
> > as
> > such.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >

//snip

> > @@ -322,6 +398,10 @@ int led_classdev_register_ext(struct device
> > *parent,
> > led_cdev->name);
> >
> > return 0;
> > +err_out:
> > + if (led_cdev->fwnode_owned)
> > + fwnode_handle_put(fw);
> > + return ret;
> > }
>
> led_cdev->fwnode_owned = false here?

I added this although with the current patch it should not be required.
The led_cdev->fwnode_owned is anyways re-initialized at the beginning
of the 'led_classdev_register_ext'. It won't eat many cycles to zero it
here though so perhaps it's safer to just do it.

I am not sure I can finish and test the patch v7 today. So it may be
next year when I am able to send it... Sorry for the delay!

Br,
Matti Vaittinen