Re: [PATCH v7 11/12] leds: Add common LED binding parsing support to LED class/core

Vaittinen, Matti
2019-12-23T10:36:09Z

Hello Pavel,

On Sat, 2019-12-21 at 20:37 +0100, Pavel Machek wrote:
> Hi!
>
> > Qucik grep for 'for_each' or 'linux,default-trigger' or
>
> quick.
>
> > If init_data is goven but no starting point for node lookup - then
>
> is given.
>
> > (parent) device's own DT node is used. If no led-compatible is
> > given,
> > then of_match is searched for. If neither led-compatible not
> > of_match
>
> nor of_match.
>
> > is given then device's own node or passed starting point are used
> > as
> > such.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >
> > No changes since v6
> >
> > drivers/leds/led-class.c | 99 +++++++++++++--
> > drivers/leds/led-core.c | 258 ++++++++++++++++++++++++++++++++---
> > ----
> > include/linux/leds.h | 94 ++++++++++++--
> > 3 files changed, 385 insertions(+), 66 deletions(-)
>
> Quite a lot of code added here. Can I trust you that we we'll delete
> 320 lines by converting driver or two?

I believe we do. Besides bunch of the lines are comments. I don't think
I actually added much of new things here. And one thing we should not
overlook is the drivers to come. I believe amount of LED devices we
will be getting drivers for will increase. 320 lines is peanuts if we
get 5 new drivers all implementing the same DT parsing loop.

Anyways, I will look all of the comments thoroughly during next Friday.
I am currently having a vacation and I might get strangled by my family
if I spend it staring at the computer xD

Thanks for taking the time to look at this! I do appreciate the effort!

Br,
Matti Vaittinen