* [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset
@ 2020-01-01 20:41 Boyan Ding
2020-01-02 9:47 ` Mika Westerberg
2020-01-08 17:42 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Boyan Ding @ 2020-01-01 20:41 UTC (permalink / raw)
To: Andy Shevchenko, Mika Westerberg, linux-gpio; +Cc: Boyan Ding, stable
Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status
offset") removes default interrupt status offset of GPIO controllers,
with previous commits explicitly providing the previously default
offsets. However, the is_offset value in SPTH_COMMUNITY is missing,
preventing related irq from being properly detected and handled.
Fixes: f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=205745
Cc: stable@vger.kernel.org
Signed-off-by: Boyan Ding <boyan.j.ding@gmail.com>
---
drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
index 44d7f50bbc82..d936e7aa74c4 100644
--- a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
+++ b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
@@ -49,6 +49,7 @@
.padown_offset = SPT_PAD_OWN, \
.padcfglock_offset = SPT_PADCFGLOCK, \
.hostown_offset = SPT_HOSTSW_OWN, \
+ .is_offset = SPT_GPI_IS, \
.ie_offset = SPT_GPI_IE, \
.pin_base = (s), \
.npins = ((e) - (s) + 1), \
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset
2020-01-01 20:41 [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset Boyan Ding
@ 2020-01-02 9:47 ` Mika Westerberg
2020-01-08 17:42 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2020-01-02 9:47 UTC (permalink / raw)
To: Boyan Ding; +Cc: Andy Shevchenko, linux-gpio, stable
On Wed, Jan 01, 2020 at 12:41:20PM -0800, Boyan Ding wrote:
> Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status
> offset") removes default interrupt status offset of GPIO controllers,
> with previous commits explicitly providing the previously default
> offsets. However, the is_offset value in SPTH_COMMUNITY is missing,
> preventing related irq from being properly detected and handled.
>
> Fixes: f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205745
> Cc: stable@vger.kernel.org
> Signed-off-by: Boyan Ding <boyan.j.ding@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset
2020-01-01 20:41 [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset Boyan Ding
2020-01-02 9:47 ` Mika Westerberg
@ 2020-01-08 17:42 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-01-08 17:42 UTC (permalink / raw)
To: Boyan Ding; +Cc: Mika Westerberg, linux-gpio, stable
On Wed, Jan 01, 2020 at 12:41:20PM -0800, Boyan Ding wrote:
> Commit 179e5a6114cc ("pinctrl: intel: Remove default Interrupt Status
> offset") removes default interrupt status offset of GPIO controllers,
> with previous commits explicitly providing the previously default
> offsets. However, the is_offset value in SPTH_COMMUNITY is missing,
> preventing related irq from being properly detected and handled.
>
Pushed to my review and testing queue, thanks!
> Fixes: f702e0b93cdb ("pinctrl: sunrisepoint: Provide Interrupt Status register offset")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205745
> Cc: stable@vger.kernel.org
> Signed-off-by: Boyan Ding <boyan.j.ding@gmail.com>
> ---
> drivers/pinctrl/intel/pinctrl-sunrisepoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
> index 44d7f50bbc82..d936e7aa74c4 100644
> --- a/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
> +++ b/drivers/pinctrl/intel/pinctrl-sunrisepoint.c
> @@ -49,6 +49,7 @@
> .padown_offset = SPT_PAD_OWN, \
> .padcfglock_offset = SPT_PADCFGLOCK, \
> .hostown_offset = SPT_HOSTSW_OWN, \
> + .is_offset = SPT_GPI_IS, \
> .ie_offset = SPT_GPI_IE, \
> .pin_base = (s), \
> .npins = ((e) - (s) + 1), \
> --
> 2.24.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-08 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-01 20:41 [PATCH] pinctrl: sunrisepoint: Add missing Interrupt Status register offset Boyan Ding
2020-01-02 9:47 ` Mika Westerberg
2020-01-08 17:42 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).