From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] gpio: Avoid kernel.h inclusion where it's possible
Date: Fri, 7 Feb 2020 00:07:32 +0200 [thread overview]
Message-ID: <20200206220732.GF10400@smile.fi.intel.com> (raw)
In-Reply-To: <20200206214729.GA30344@bogus>
On Thu, Feb 06, 2020 at 02:47:29PM -0700, Rob Herring wrote:
> On Wed, Feb 05, 2020 at 03:43:36PM +0200, Andy Shevchenko wrote:
> > Inclusion of kernel.h increases the mess with the header dependencies.
> > Avoid kernel.h inclusion where it's possible.
> > Besides that, clean up a bit other inclusions inside GPIO subsystem headers.
> > It includes:
> > - removal pin control bits (forward declaration and header) from linux/gpio.h
> > - removal of.h from asm-generic/gpio.h
> > - use of explicit headers in gpio/consumer.h
> > - add FIXME note with regard to gpio.h inclusion in of_gpio,h
...
> > #else /* !CONFIG_GPIOLIB */
> >
> > +#include <linux/kernel.h>
> > +
>
> I don't really think moving the includes inside #ifdef's is an
> improvment.
I also not a big fun, but for now it removes in most cases when
CONFIG_GPIOLIB=y. And this is already an improvement. Next step is to replace
it with newly created (when it will be created) header might_sleep.h.
> But I'll leave it to Linus.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-06 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 13:43 [PATCH v2] gpio: Avoid kernel.h inclusion where it's possible Andy Shevchenko
2020-02-06 21:47 ` Rob Herring
2020-02-06 22:07 ` Andy Shevchenko [this message]
2020-02-10 11:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206220732.GF10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox