Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Daniel Mor <dmlinuxnewbie@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Daniel Mor <dmlinuxnewbie@gmail.com>
Subject: [PATCH 2/2] core: Removing unnecessary check for monitoring multiple lines.
Date: Sat,  8 Feb 2020 12:01:29 +0200	[thread overview]
Message-ID: <20200208100129.10657-1-dmlinuxnewbie@gmail.com> (raw)

In case when needed to monitor multiple line`s on different chip`s
function gpiod_line_event_wait_bulk() blocking it, by checking if
the line`s in a bulk from same chip.
In current state the API forsing the user to wait for notification on multiple threads.

Signed-off-by: Daniel Mor <dmlinuxnewbie@gmail.com>
---
 lib/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/core.c b/lib/core.c
index ed63012..2a46074 100644
--- a/lib/core.c
+++ b/lib/core.c
@@ -977,7 +977,7 @@ int gpiod_line_event_wait_bulk(struct gpiod_line_bulk *bulk,
 	struct gpiod_line *line;
 	int rv;
 
-	if (!line_bulk_same_chip(bulk) || !line_bulk_all_requested(bulk))
+	if (!line_bulk_all_requested(bulk))
 		return -1;
 
 	memset(fds, 0, sizeof(fds));
-- 
2.17.1


             reply	other threads:[~2020-02-08 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-08 10:01 Daniel Mor [this message]
2020-02-09 11:27 ` [PATCH 2/2] core: Removing unnecessary check for monitoring multiple lines Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200208100129.10657-1-dmlinuxnewbie@gmail.com \
    --to=dmlinuxnewbie@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox