* [PATCH v1] gpiolib: Fix wrong appearance of critical message in gpiochip_remove()
@ 2020-03-02 9:43 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2020-03-02 9:43 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, Bartosz Golaszewski; +Cc: Andy Shevchenko
When the commit 869233f81337 ("gpiolib: Optimize gpiochip_remove()
when check for requested line") refactored a for-loop, the condition
to check if we found requested line was mistakenly inverted. So, fix
the condition to avoid critical message when it's not supposed to be
printed.
Fixes: 869233f81337 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ea2d05cfb5eb..1f986ba3502a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1846,7 +1846,7 @@ void gpiochip_remove(struct gpio_chip *chip)
}
spin_unlock_irqrestore(&gpio_lock, flags);
- if (i == gdev->ngpio)
+ if (i < gdev->ngpio)
dev_crit(&gdev->dev,
"REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED\n");
--
2.25.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-02 9:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-02 9:43 [PATCH v1] gpiolib: Fix wrong appearance of critical message in gpiochip_remove() Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).