From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5698AC3F2D7 for ; Mon, 2 Mar 2020 14:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E67C2467B for ; Mon, 2 Mar 2020 14:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbgCBOXP (ORCPT ); Mon, 2 Mar 2020 09:23:15 -0500 Received: from mga11.intel.com ([192.55.52.93]:24977 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbgCBOXP (ORCPT ); Mon, 2 Mar 2020 09:23:15 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 06:23:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="351551237" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 02 Mar 2020 06:23:12 -0800 Received: by lahna (sSMTP sendmail emulation); Mon, 02 Mar 2020 16:23:11 +0200 Date: Mon, 2 Mar 2020 16:23:11 +0200 From: Mika Westerberg To: Hans de Goede Cc: Andy Shevchenko , Bartosz Golaszewski , Linus Walleij , Marc Lehmann , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 1/4] gpiolib: acpi: Correct comment for HP x2 10 honor_wakeup quirk Message-ID: <20200302142311.GD2667@lahna.fi.intel.com> References: <20200302111225.6641-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302111225.6641-1-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 02, 2020 at 12:12:22PM +0100, Hans de Goede wrote: > Commit aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + > quirk mechanism") added a quirk for some models of the HP x2 10 series. > > There are 2 issues with the comment describing the quirk: > 1) The comment claims the DMI quirk applies to all Cherry Trail based HP x2 > 10 models. In the mean time I have learned that there are at least 3 > models of the HP x2 10 models: > > Bay Trail SoC + AXP288 PMIC > Cherry Trail SoC + AXP288 PMIC > Cherry Trail SoC + TI PMIC > > And this quirk's DMI matches only match the Cherry Trail SoC + TI PMIC > SoC, which is good because we want a slightly different quirk for the > others. This commit updates the comment to make it clear that the quirk > is only for the Cherry Trail SoC + TI PMIC models. > > 2) The comment says that it is ok to disable wakeup on all ACPI GPIO event > handlers, because there is only the one for the embedded-controller > events. This is not true, there also is a handler for the special > INT0002 device which is related to USB wakeups. We need to also disable > wakeups on that one because the device turns of the USB-keyboard built > into the dock when closing the lid. The XHCI controller takes a while > to notice this, so it only notices it when already suspended, causing > a spurious wakeup because of this. So disabling wakeup on all handlers > is the right thing to do, but not because there only is the one handler > for the EC events. This commit updates the comment to correctly reflect > this. > > Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") Not sure if Fixes tag is needed if you only correct comment but fine :) > Signed-off-by: Hans de Goede Acked-by: Mika Westerberg