From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B42C3F2C6 for ; Tue, 3 Mar 2020 14:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE71F20857 for ; Tue, 3 Mar 2020 14:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583246450; bh=voICwXfMkCOmnvzzQLkAXsaE1rkTpvZ6JQkQpIcrKqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gm7ZUMIcnMFO5NQSxbcohfC41+HQRtk6O0fWSZNOam7rRw4o1LkJgmpuaOZgXgU89 JWZkF34abeX05GEr3iG6OaUTJulal9lHRMf/R09jolOYObfepcCq07bfyVg5tXnaGj 045hKsXG2TK2IqQfGwzS2LPU92+kNdcQKX5Fgspo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729502AbgCCOku (ORCPT ); Tue, 3 Mar 2020 09:40:50 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:34194 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbgCCOku (ORCPT ); Tue, 3 Mar 2020 09:40:50 -0500 Received: by mail-oi1-f194.google.com with SMTP id g6so3264737oiy.1; Tue, 03 Mar 2020 06:40:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pBPgC25ubKS5wPAN+uT8vJ9mnR6iCFqlpOC1P57sXK4=; b=b/mv7Xnf/rxY3UZFUp4Oqt0ljveaMBQnfClAIulPVvDDJEEVLbm1f3k69cEdsxjIae OAvdfUMoR0Mf68yaMoaVmrgCAtX5D3RAu87nNyWvsCCxXc3sOasEpqNdRhN1GTVLdwrc otppVsuN5amwqbajLnHPTDzw7TN0cmX41mx/zSz+F8eYNOEtMKobAm0KOSBOqBsEl4nI PJMQg8YePLSfFIi+2N2GBbPA+wGb15NaqotRolqcCfSnusKNU44w2aX1pLeSS2iCr5DP eO4ohmbduuAe2PdYByETzT8gIWq0dMSLmqSw1wieCJ6t3Q449rBJlp5yf/5qKygzhdpd RWPQ== X-Gm-Message-State: ANhLgQ1HhBLyeYWFlBd1SEoSyr+JYh6+utUaZYkAkbm4wpgHZP54BvUs NyAiImWhNIOb5RDk1pztWw== X-Google-Smtp-Source: ADFU+vv05XHH/grNWOM44+Loiz7eSQ7oRdXeA6SR+r3YHZMxgPfK8MbbrKBZbP66Sthy2ocwKowBzg== X-Received: by 2002:a54:4006:: with SMTP id x6mr2678057oie.145.1583246449504; Tue, 03 Mar 2020 06:40:49 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a26sm6034251oid.17.2020.03.03.06.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 06:40:48 -0800 (PST) Received: (nullmailer pid 5880 invoked by uid 1000); Tue, 03 Mar 2020 14:40:47 -0000 Date: Tue, 3 Mar 2020 08:40:47 -0600 From: Rob Herring To: "H. Nikolaus Schaller" Cc: Paul Cercueil , Paul Boddie , David Airlie , Daniel Vetter , Mark Rutland , Ralf Baechle , Paul Burton , Linus Walleij , Andi Kleen , Krzysztof Kozlowski , Geert Uytterhoeven , "Eric W. Biederman" , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, Zubair Lutfullah Kakakhel Subject: Re: [RFC 2/8] dt-bindings: video: Add jz4780-hdmi binding Message-ID: <20200303144047.GA24762@bogus> References: <2d7202155bae3fa9c7097275d4c9a1ccab569aea.1582744379.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d7202155bae3fa9c7097275d4c9a1ccab569aea.1582744379.git.hns@goldelico.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Feb 26, 2020 at 08:12:54PM +0100, H. Nikolaus Schaller wrote: > From: Zubair Lutfullah Kakakhel > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > .../bindings/display/ingenic-jz4780-hdmi.txt | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt > > diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt > new file mode 100644 > index 000000000000..f02e59fbdd5a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt > @@ -0,0 +1,41 @@ > +Device-Tree bindings for Ingenic JZ4780 HDMI Transmitter > + > +The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4 > +TX controller IP with accompanying PHY IP. > + > +Required properties: > + - #address-cells : should be <1> > + - #size-cells : should be <0> These aren't in the example. > + - compatible : should be "ingenic,jz4780-hdmi" > + - reg-io-width: must be <4> If it can only be 4, then you can just assume that from the compatible. > + - clocks: phandle to isrf and iahb clocks > + - clock-names : must be "isrf" and "iahb" > + - ports: Port nodes with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt, > + > +Optional properties: > + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing This goes in a connector node. It's not part of the HDMI block. That also means you need an out port to the connector. > + > +example: > + > +hdmi: hdmi@10180000 { > + compatible = "ingenic,jz4780-hdmi"; > + reg = <0x10180000 0x8000>; > + reg-io-width = <4>; > + ddc-i2c-bus = <&i2c4>; > + interrupt-parent = <&intc>; > + interrupts = <3>; > + clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>; > + clock-names = "isfr", "iahb"; > + > + ports { > + hdmi_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + hdmi_in_lcd: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&jz4780_out_hdmi>; > + }; > + }; > + }; > +}; > -- > 2.23.0 >