From: Marco Felsch <m.felsch@pengutronix.de>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Support Opensource <support.opensource@diasemi.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: da9062: Fix include path
Date: Tue, 17 Mar 2020 22:10:20 +0100 [thread overview]
Message-ID: <20200317211020.4ozletmpvz67jytb@pengutronix.de> (raw)
In-Reply-To: <773115.1584420899@turing-police>
Hi,
On 20-03-17 00:54, Valdis Klētnieks wrote:
> Found during a allmodconfig build on ARM on an RPi4:
>
> CC drivers/pinctrl/pinctrl-da9062.o
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
> compilation terminated.
this should be fixed already:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/pinctrl/pinctrl-da9062.c?id=2353810dac9ab72d3f835e3fb015c6819a0ef6c2
Regards,
Marco
>
> So... fix the errant include.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Fixes: 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..cfbe529e66c3 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include <../drivers/gpio/gpiolib.h>
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2020-03-17 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 4:54 [PATCH] pinctrl: da9062: Fix include path Valdis Klētnieks
2020-03-17 21:10 ` Marco Felsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317211020.4ozletmpvz67jytb@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).