From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v1 2/2] [RFC] gpio: pca953x: drop unused parameters of pca953x_recalc_addr()
Date: Sat, 28 Mar 2020 10:27:30 +0100 [thread overview]
Message-ID: <20200328092730.rn7drxqtx7g2xsff@pengutronix.de> (raw)
In-Reply-To: <DF902AF8-CA86-4F31-9D98-288D40634D69@goldelico.com>
On Fri, Mar 27, 2020 at 11:06:43PM +0100, H. Nikolaus Schaller wrote:
>
> > Am 27.03.2020 um 18:22 schrieb Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> >
> > After the previous patch the two last parameters of
> > pca953x_recalc_addr() are unused and so can be dropped.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/gpio/gpio-pca953x.c | 31 +++++++++++--------------------
> > 1 file changed, 11 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> > index 8168558299c2..f4943cad5d0e 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -325,8 +325,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
> > .max_register = 0x7f,
> > };
> >
> > -static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off,
> > - bool write, bool addrinc)
> > +static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off)
> > {
> > int bank_shift = pca953x_bank_shift(chip);
> > int addr = (reg & PCAL_GPIO_MASK) << bank_shift;
> > @@ -338,7 +337,7 @@ static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off,
> >
> > static int pca953x_write_regs(struct pca953x_chip *chip, int reg, unsigned long *val)
> > {
> > - u8 regaddr = pca953x_recalc_addr(chip, reg, 0, true, true);
> > + u8 regaddr = pca953x_recalc_addr(chip, reg, 0;
>
> here is some ")" missing.
>
> After fix&compile it still works for the pcal6524 of the OMAP5/Pyra
> (LPAE build).
Argh, it seems I didn't try to recompile after rebasing :-|
I'm still waiting for more feedback and then will send out a v2.
Thanks for your test,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-03-28 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 7:49 register access issues in pca953x gpio driver Uwe Kleine-König
2020-03-27 10:26 ` Andy Shevchenko
2020-03-27 13:49 ` Uwe Kleine-König
2020-03-27 13:03 ` Mark Brown
2020-03-27 13:46 ` Uwe Kleine-König
2020-03-27 13:58 ` Mark Brown
2020-03-27 17:22 ` [PATCH v1 0/2] gpio: pca953x: fix handling of automatic address incrementing Uwe Kleine-König
2020-03-27 17:22 ` [PATCH v1 1/2] [RFC] " Uwe Kleine-König
2020-03-27 17:22 ` [PATCH v1 2/2] [RFC] gpio: pca953x: drop unused parameters of pca953x_recalc_addr() Uwe Kleine-König
2020-03-27 22:06 ` H. Nikolaus Schaller
2020-03-28 9:27 ` Uwe Kleine-König [this message]
2020-03-28 19:41 ` Andy Shevchenko
2020-03-30 14:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328092730.rn7drxqtx7g2xsff@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pengutronix.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).