From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, Serge Semin <fancer.lancer@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 01/13] gpio: dwapb: Append MODULE_ALIAS for platform driver
Date: Thu, 9 Apr 2020 17:12:16 +0300 [thread overview]
Message-ID: <20200409141228.49561-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200409141228.49561-1-andriy.shevchenko@linux.intel.com>
The commit 3d2613c4289f
("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver")
introduced a use of the platform driver but missed to add the following line
to it:
MODULE_ALIAS("platform:gpio-dwapb");
Add this to get driver loaded automatically if platform device is registered.
Fixes: 3d2613c4289f ("GPIO: gpio-dwapb: Enable platform driver binding to MFD driver")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-dwapb.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index d2ed11510f3c..c1b6d4f7307e 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -49,7 +49,9 @@
#define GPIO_EXT_PORTC 0x58
#define GPIO_EXT_PORTD 0x5c
+#define DWAPB_DRIVER_NAME "gpio-dwapb"
#define DWAPB_MAX_PORTS 4
+
#define GPIO_EXT_PORT_STRIDE 0x04 /* register stride 32 bits */
#define GPIO_SWPORT_DR_STRIDE 0x0c /* register stride 3*32 bits */
#define GPIO_SWPORT_DDR_STRIDE 0x0c /* register stride 3*32 bits */
@@ -400,7 +402,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
return;
err = irq_alloc_domain_generic_chips(gpio->domain, ngpio, 2,
- "gpio-dwapb", handle_level_irq,
+ DWAPB_DRIVER_NAME, handle_level_irq,
IRQ_NOREQUEST, 0,
IRQ_GC_INIT_NESTED_LOCK);
if (err) {
@@ -457,7 +459,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
*/
err = devm_request_irq(gpio->dev, pp->irq[0],
dwapb_irq_handler_mfd,
- IRQF_SHARED, "gpio-dwapb-mfd", gpio);
+ IRQF_SHARED, DWAPB_DRIVER_NAME, gpio);
if (err) {
dev_err(gpio->dev, "error requesting IRQ\n");
irq_domain_remove(gpio->domain);
@@ -847,7 +849,7 @@ static SIMPLE_DEV_PM_OPS(dwapb_gpio_pm_ops, dwapb_gpio_suspend,
static struct platform_driver dwapb_gpio_driver = {
.driver = {
- .name = "gpio-dwapb",
+ .name = DWAPB_DRIVER_NAME,
.pm = &dwapb_gpio_pm_ops,
.of_match_table = of_match_ptr(dwapb_of_match),
.acpi_match_table = ACPI_PTR(dwapb_acpi_match),
@@ -861,3 +863,4 @@ module_platform_driver(dwapb_gpio_driver);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Jamie Iles");
MODULE_DESCRIPTION("Synopsys DesignWare APB GPIO driver");
+MODULE_ALIAS("platform:" DWAPB_DRIVER_NAME);
--
2.25.1
next prev parent reply other threads:[~2020-04-09 14:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 14:12 [PATCH v1 00/13] gpio: dwapb: Clean up the driver and a fix Andy Shevchenko
2020-04-09 14:12 ` Andy Shevchenko [this message]
2020-04-15 11:58 ` [PATCH v1 01/13] gpio: dwapb: Append MODULE_ALIAS for platform driver Serge Semin
2020-04-09 14:12 ` [PATCH v1 02/13] gpio: dwapb: Refactor IRQ handler Andy Shevchenko
2020-04-15 12:04 ` Serge Semin
2020-04-15 12:35 ` Andy Shevchenko
2020-04-09 14:12 ` [PATCH v1 03/13] gpio: dwapb: set default handler to be handle_bad_irq() Andy Shevchenko
2020-04-15 12:22 ` Serge Semin
2020-04-15 12:33 ` Andy Shevchenko
2020-04-09 14:12 ` [PATCH v1 04/13] gpio: dwapb: Deduplicate IRQ resource management Andy Shevchenko
2020-04-15 12:28 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 05/13] gpio: dwapb: Convert to use irqd_to_hwirq() Andy Shevchenko
2020-04-15 12:42 ` Serge Semin
2020-04-15 13:16 ` Andy Shevchenko
2020-04-09 14:12 ` [PATCH v1 06/13] gpio: dwapb: Use device_get_match_data() to simplify code Andy Shevchenko
2020-04-15 12:46 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 07/13] gpio: dwapb: Convert to use IRQ core provided macros Andy Shevchenko
2020-04-15 12:57 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 08/13] gpio: dwapb: Switch to more usual pattern of RMW in dwapb_gpio_set_debounce() Andy Shevchenko
2020-04-15 13:00 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 09/13] gpio: dwapb: Drop bogus BUG_ON()s Andy Shevchenko
2020-04-15 13:05 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 10/13] gpio: dwapb: Drop of_match_ptr() & ACPI_PTR() calls Andy Shevchenko
2020-04-15 13:07 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 11/13] gpio: dwapb: Split out dwapb_get_irq() helper Andy Shevchenko
2020-04-15 13:13 ` Serge Semin
2020-04-09 14:12 ` [PATCH v1 12/13] gpio: dwapb: Use positive conditional in dwapb_configure_irqs() Andy Shevchenko
2020-04-09 14:12 ` [PATCH v1 13/13] gpio: dwapb: Amend indentation in some cases Andy Shevchenko
2020-04-09 14:28 ` [PATCH v1 00/13] gpio: dwapb: Clean up the driver and a fix Serge Semin
2020-04-15 11:55 ` Serge Semin
2020-04-15 12:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409141228.49561-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).