From: Sergey Semin <fancer.lancer@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 2/2] gpio: dwapb: Amend indentation in some cases
Date: Wed, 22 Apr 2020 19:32:55 +0300 [thread overview]
Message-ID: <20200422163255.23ch3kbhn6gx2kpg@mobilestation> (raw)
In-Reply-To: <20200422110654.23442-2-andriy.shevchenko@linux.intel.com>
On Wed, Apr 22, 2020 at 02:06:54PM +0300, Andy Shevchenko wrote:
> In some cases indentation makes code harder to read. Amend indentation
> in those cases despite of lines go a bit over 80 character limit.
Acked-by: Serge Semin <fancer.lancer@gmail.com>
>
> Cc: Serge Semin <fancer.lancer@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-dwapb.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 9d8476afaba3d..8639c4a7f4697 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -437,7 +437,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
> }
> }
>
> - for (hwirq = 0 ; hwirq < ngpio ; hwirq++)
> + for (hwirq = 0; hwirq < ngpio; hwirq++)
> irq_create_mapping(gpio->domain, hwirq);
>
> port->gc.to_irq = dwapb_gpio_to_irq;
> @@ -453,7 +453,7 @@ static void dwapb_irq_teardown(struct dwapb_gpio *gpio)
> if (!gpio->domain)
> return;
>
> - for (hwirq = 0 ; hwirq < ngpio ; hwirq++)
> + for (hwirq = 0; hwirq < ngpio; hwirq++)
> irq_dispose_mapping(irq_find_mapping(gpio->domain, hwirq));
>
> irq_domain_remove(gpio->domain);
> @@ -478,10 +478,9 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> return -ENOMEM;
> #endif
>
> - dat = gpio->regs + GPIO_EXT_PORTA + (pp->idx * GPIO_EXT_PORT_STRIDE);
> - set = gpio->regs + GPIO_SWPORTA_DR + (pp->idx * GPIO_SWPORT_DR_STRIDE);
> - dirout = gpio->regs + GPIO_SWPORTA_DDR +
> - (pp->idx * GPIO_SWPORT_DDR_STRIDE);
> + dat = gpio->regs + GPIO_EXT_PORTA + pp->idx * GPIO_EXT_PORT_STRIDE;
> + set = gpio->regs + GPIO_SWPORTA_DR + pp->idx * GPIO_SWPORT_DR_STRIDE;
> + dirout = gpio->regs + GPIO_SWPORTA_DDR + pp->idx * GPIO_SWPORT_DDR_STRIDE;
>
> /* This registers 32 GPIO lines per port */
> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,
> @@ -588,8 +587,7 @@ static struct dwapb_platform_data *dwapb_gpio_get_pdata(struct device *dev)
> return ERR_PTR(-EINVAL);
> }
>
> - if (fwnode_property_read_u32(fwnode, "snps,nr-gpios",
> - &pp->ngpio)) {
> + if (fwnode_property_read_u32(fwnode, "snps,nr-gpios", &pp->ngpio)) {
> dev_info(dev,
> "failed to get number of gpios for port%d\n",
> i);
> --
> 2.26.1
>
next prev parent reply other threads:[~2020-04-22 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 11:06 [PATCH v1 1/2] gpio: dwapb: Get rid of unnecessary conjunction over 32-bit value Andy Shevchenko
2020-04-22 11:06 ` [PATCH v1 2/2] gpio: dwapb: Amend indentation in some cases Andy Shevchenko
2020-04-22 16:32 ` Sergey Semin [this message]
2020-04-22 16:28 ` [PATCH v1 1/2] gpio: dwapb: Get rid of unnecessary conjunction over 32-bit value Sergey Semin
2020-04-28 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422163255.23ch3kbhn6gx2kpg@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).