From: Dejin Zheng <zhengdejin5@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v1] gpio: fix several typos
Date: Fri, 24 Apr 2020 23:09:18 +0800 [thread overview]
Message-ID: <20200424150918.GB8853@nuc8i5> (raw)
In-Reply-To: <CAMpxmJUzrWRuHV-=EOgjd-N-iwhZwVGzF26tH0ybpzZQSP6VJQ@mail.gmail.com>
On Fri, Apr 24, 2020 at 08:39:04AM +0200, Bartosz Golaszewski wrote:
> niedz., 19 kwi 2020 o 18:38 Dejin Zheng <zhengdejin5@gmail.com> napisał(a):
> >
> > Use codespell to fix lots of typos over frontends.
> >
> > CC: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> > ---
> > drivers/gpio/gpio-ftgpio010.c | 2 +-
> > drivers/gpio/gpio-mm-lantiq.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> > index fbddb1662428..4031164780f7 100644
> > --- a/drivers/gpio/gpio-ftgpio010.c
> > +++ b/drivers/gpio/gpio-ftgpio010.c
> > @@ -193,7 +193,7 @@ static int ftgpio_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> > if (val == deb_div) {
> > /*
> > * The debounce timer happens to already be set to the
> > - * desireable value, what a coincidence! We can just enable
> > + * desirable value, what a coincidence! We can just enable
> > * debounce on this GPIO line and return. This happens more
> > * often than you think, for example when all GPIO keys
> > * on a system are requesting the same debounce interval.
> > diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c
> > index f460d71b0c92..538e31fe8903 100644
> > --- a/drivers/gpio/gpio-mm-lantiq.c
> > +++ b/drivers/gpio/gpio-mm-lantiq.c
> > @@ -36,7 +36,7 @@ struct ltq_mm {
> > * @chip: Pointer to our private data structure.
> > *
> > * Write the shadow value to the EBU to set the gpios. We need to set the
> > - * global EBU lock to make sure that PCI/MTD dont break.
> > + * global EBU lock to make sure that PCI/MTD don't break.
> > */
> > static void ltq_mm_apply(struct ltq_mm *chip)
> > {
> > --
> > 2.25.0
> >
>
> The subject line should be gpio: <name of the driver>: short message
>
> And please split those into patches for each driver.
>
Hi Bart:
Thanks for your review, I will send the patch v2 for this change.
BR,
Dejin
> Bart
prev parent reply other threads:[~2020-04-24 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 16:38 [PATCH v1] gpio: fix several typos Dejin Zheng
2020-04-24 6:39 ` Bartosz Golaszewski
2020-04-24 15:09 ` Dejin Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424150918.GB8853@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox