From: Rob Herring <robh@kernel.org>
To: Jaedon Shin <jaedon.shin@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Jaedon Shin <jaedon.shin@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH v2 2/2] PCI: brcmstb: Drop clk_put when probe fails and remove
Date: Thu, 7 May 2020 13:55:09 -0500 [thread overview]
Message-ID: <20200507185509.GA913@bogus> (raw)
In-Reply-To: <20200221033640.55163-3-jaedon.shin@gmail.com>
On Fri, 21 Feb 2020 12:36:40 +0900, Jaedon Shin wrote:
> devm_clk_get* APIs are device managed and get freed automatically when
> the device detaches. so there is no reason to explicitly call clk_put()
> in probe or remove functions.
>
> Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host
> controller driver")
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2020-05-07 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 3:36 [PATCH v2 0/2] PCI: brcmstb: Add Broadcom STB support Jaedon Shin
2020-02-21 3:36 ` [PATCH v2 1/2] PCI: brcmstb: Add regulator support Jaedon Shin
2020-02-21 12:12 ` Mark Brown
2020-02-21 16:33 ` Florian Fainelli
2020-02-21 17:11 ` Mark Brown
2020-02-21 17:50 ` Florian Fainelli
2020-02-21 17:57 ` Mark Brown
2020-02-21 3:36 ` [PATCH v2 2/2] PCI: brcmstb: Drop clk_put when probe fails and remove Jaedon Shin
2020-05-07 18:55 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507185509.GA913@bogus \
--to=robh@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).