From: Serge Semin <fancer.lancer@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 1/4] gpio: dwapb: avoid error message for optional IRQ
Date: Sun, 17 May 2020 15:22:49 +0300 [thread overview]
Message-ID: <20200517122249.mpkw4tnpfraqttbk@mobilestation> (raw)
In-Reply-To: <20200512184513.86883-1-andriy.shevchenko@linux.intel.com>
Hello Andy,
Thanks for sending this cleanup series. By comments are below and inlined in the
individual patches further in the patchset.
On Tue, May 12, 2020 at 09:45:10PM +0300, Andy Shevchenko wrote:
> platform_get_irq() will generate an error message if the requested IRQ
> is not present. Use platform_get_irq_optional() to avoid the error message
> being generated.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Serge Semin <fancer.lancer@gmail.com>
> ---
> drivers/gpio/gpio-dwapb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 8639c4a7f46974..5bc5057f071f37 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -542,7 +542,7 @@ static void dwapb_get_irq(struct device *dev, struct fwnode_handle *fwnode,
> if (np)
> pp->irq[j] = of_irq_get(np, j);
> else if (has_acpi_companion(dev))
> - pp->irq[j] = platform_get_irq(to_platform_device(dev), j);
> + pp->irq[j] = platform_get_irq_optional(to_platform_device(dev), j);
If only we didn't have sub-nodes describing the GPIO ports, we could have used
the platform_get_irq_optional() here for both DT and ACPI based devices...
Since we do, there is no way but to have the "if (np) else if(has_acpi_companion())"
conditional statement here. Thanks for sending this patch.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
>
> if (pp->irq[j] >= 0)
> pp->has_irq = true;
> --
> 2.26.2
>
prev parent reply other threads:[~2020-05-17 12:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 18:45 [PATCH v1 1/4] gpio: dwapb: avoid error message for optional IRQ Andy Shevchenko
2020-05-12 18:45 ` [PATCH v1 2/4] gpio: dwapb: Don't use 0 as valid Linux interrupt number Andy Shevchenko
2020-05-17 12:52 ` Serge Semin
2020-05-18 16:12 ` Andy Shevchenko
2020-05-12 18:45 ` [PATCH v1 3/4] gpio: dwapb: Drop extra check to call acpi_gpiochip_request_interrupts() Andy Shevchenko
2020-05-17 13:55 ` Serge Semin
2020-05-17 14:47 ` Serge Semin
2020-05-18 17:03 ` Andy Shevchenko
2020-05-18 17:07 ` Andy Shevchenko
2020-05-12 18:45 ` [PATCH v1 4/4] gpio: dwapb: Remove unneeded has_irq member in struct dwapb_port_property Andy Shevchenko
2020-05-12 22:53 ` kbuild test robot
2020-05-13 10:22 ` Andy Shevchenko
2020-05-13 12:39 ` kbuild test robot
2020-05-17 14:26 ` Serge Semin
2020-05-18 17:27 ` Andy Shevchenko
2020-05-13 14:43 ` [PATCH v1 1/4] gpio: dwapb: avoid error message for optional IRQ Andy Shevchenko
2020-05-14 11:59 ` Serge Semin
2020-05-17 12:22 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517122249.mpkw4tnpfraqttbk@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox