From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF77C433E0 for ; Mon, 18 May 2020 18:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03FEF207D3 for ; Mon, 18 May 2020 18:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbgERSIK (ORCPT ); Mon, 18 May 2020 14:08:10 -0400 Received: from mga04.intel.com ([192.55.52.120]:52238 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387476AbgERSIG (ORCPT ); Mon, 18 May 2020 14:08:06 -0400 IronPort-SDR: hQHbOb/DZPGZdebzS3UG19w42BzD+mKIbMt0VDx7je8lwQEjXz0K+2qU+v6ioPdFN85dYH3NOi 1+LHN3Q4P1Zg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 11:08:05 -0700 IronPort-SDR: 0dxA0UFvx+Pb/ojvB39UQ7fqxhU6WCZl/m+Mehkl0pgpkUwr4kyVL7U5kDAPffCMRmpYb7xXpb 22bfwgRXV67w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="411348411" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 18 May 2020 11:08:03 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jakBK-007U6m-Ov; Mon, 18 May 2020 21:08:06 +0300 Date: Mon, 18 May 2020 21:08:06 +0300 From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Cc: Serge Semin , Lee Jones Subject: Re: [PATCH v2 4/4] gpio: dwapb: Remove unneeded has_irq member in struct dwapb_port_property Message-ID: <20200518180806.GQ1634618@smile.fi.intel.com> References: <20200518174138.19367-1-andriy.shevchenko@linux.intel.com> <20200518174138.19367-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518174138.19367-4-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, May 18, 2020 at 08:41:38PM +0300, Andy Shevchenko wrote: > has_irq member of struct dwapb_port_property is used only in one place, > so, make it local test instead and remove from the structure. > This local test is using memchr_inv() which is quite effective in comparison > to the original loop and possible little overhead can be neglected. > > Signed-off-by: Andy Shevchenko > Cc: Serge Semin > Cc: Lee Jones > --- > v2: > - fixed compilation error (kbuild bot) > - added Lee into Cc Lee, JFYI, you have not been forgotten in the v1, this is due to missed change in the MFD driver in v1 and since kbuild bot reported it this is the first version which includes MFD changes. > - moved memchr_inv() here (Serge) -- With Best Regards, Andy Shevchenko