linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: Add gpio-charger to the documentation
@ 2020-06-10  9:51 Linus Walleij
  2020-06-10 14:01 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2020-06-10  9:51 UTC (permalink / raw)
  To: linux-gpio; +Cc: Bartosz Golaszewski, Linus Walleij, Sebastian Reichel

The GPIO-based charger is another of the helpful devices built
on top of GPIO.

Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 Documentation/driver-api/gpio/drivers-on-gpio.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/driver-api/gpio/drivers-on-gpio.rst b/Documentation/driver-api/gpio/drivers-on-gpio.rst
index 820b403d50f6..d85fb748cc52 100644
--- a/Documentation/driver-api/gpio/drivers-on-gpio.rst
+++ b/Documentation/driver-api/gpio/drivers-on-gpio.rst
@@ -89,6 +89,13 @@ hardware descriptions such as device tree or ACPI:
   Consumer Electronics Control bus using only GPIO. It is used to communicate
   with devices on the HDMI bus.
 
+- gpio-charger: drivers/power/supply/gpio-charger.c is used if you need to do
+  battery charging and all you have to go by to check the presence of the
+  battery or more complex tasks such as indicating charging status using
+  nothing but GPIO lines, this driver provides that and also a clearly defined
+  way to pass the charging parameters from hardware descriptions such as the
+  device tree.
+
 Apart from this there are special GPIO drivers in subsystems like MMC/SD to
 read card detect and write protect GPIO lines, and in the TTY serial subsystem
 to emulate MCTRL (modem control) signals CTS/RTS by using two GPIO lines. The
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: Add gpio-charger to the documentation
  2020-06-10  9:51 [PATCH] gpio: Add gpio-charger to the documentation Linus Walleij
@ 2020-06-10 14:01 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-06-10 14:01 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio, Bartosz Golaszewski

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

Hi Linus,

On Wed, Jun 10, 2020 at 11:51:24AM +0200, Linus Walleij wrote:
> The GPIO-based charger is another of the helpful devices built
> on top of GPIO.
> 
> Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/driver-api/gpio/drivers-on-gpio.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/driver-api/gpio/drivers-on-gpio.rst b/Documentation/driver-api/gpio/drivers-on-gpio.rst
> index 820b403d50f6..d85fb748cc52 100644
> --- a/Documentation/driver-api/gpio/drivers-on-gpio.rst
> +++ b/Documentation/driver-api/gpio/drivers-on-gpio.rst
> @@ -89,6 +89,13 @@ hardware descriptions such as device tree or ACPI:
>    Consumer Electronics Control bus using only GPIO. It is used to communicate
>    with devices on the HDMI bus.
>  
> +- gpio-charger: drivers/power/supply/gpio-charger.c is used if you need to do
> +  battery charging and all you have to go by to check the presence of the
> +  battery

The presence being checked and reported to userspace is for the AC
adapter, not the battery. Battery presence is handled by battery
driver (e.g. sbs-battery has a detect gpio).

> +          or more complex tasks such as indicating charging status using
> +  nothing but GPIO lines, this driver provides that and also a clearly defined
> +  way to pass the charging parameters from hardware descriptions such as the
> +  device tree.
> +
>  Apart from this there are special GPIO drivers in subsystems like MMC/SD to
>  read card detect and write protect GPIO lines, and in the TTY serial subsystem
>  to emulate MCTRL (modem control) signals CTS/RTS by using two GPIO lines. The

Otherwise LGTM.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-10 14:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-10  9:51 [PATCH] gpio: Add gpio-charger to the documentation Linus Walleij
2020-06-10 14:01 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).