From: Rob Herring <robh@kernel.org>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: "Hyun Kwon" <hyunk@xilinx.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
sakari.ailus@iki.fi, linux-media@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hans Verkuil" <hverkuil@xs4all.nl>,
linux-renesas-soc@vger.kernel.org,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
devicetree@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Jacopo Mondi" <jacopo@jmondi.org>
Subject: Re: [PATCH v10 3/4] dt-bindings: media: i2c: Add bindings for IMI RDACM2x
Date: Fri, 12 Jun 2020 16:11:03 -0600 [thread overview]
Message-ID: <20200612221103.GA3902762@bogus> (raw)
In-Reply-To: <20200612144713.502006-4-kieran.bingham+renesas@ideasonboard.com>
On Fri, 12 Jun 2020 15:47:12 +0100, Kieran Bingham wrote:
> From: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> The IMI RDACM20 and IMI RDACM21 are Gigabit Multimedia Serial Link
> (GMSL) camera capable of transmitting video and I2C control messages on
> a coax cable physical link for automotive applications.
>
> Document their device tree bindings.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> ---
> v2:
> - Provide imi vendor prefix
> - Fix minor spelling
>
> v3:
> - update binding descriptions
>
> v4:
> - No change
>
> v5:
> - Specify optional third reg address for the MCU
>
> v7:
> [Jacopo]
> - Rename to imi,rdacm2x-gmsl.yaml
> - Exand bindings to describe RDACM21
>
> v9:
> [Jacopo]
> - Rework 'compatible' property as suggested by Rob
> - Re-order vendor prefixes ('g' comes before 'i' ... )
> - Add Rob's tag
>
> .../bindings/media/i2c/imi,rdacm2x-gmsl.yaml | 159 ++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> 2 files changed, 161 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.example.dt.yaml: example-0: i2c@e66d8000:reg:0: [0, 3865935872, 0, 64] is too long
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.example.dt.yaml: example-1: i2c@e66d8000:reg:0: [0, 3865935872, 0, 64] is too long
See https://patchwork.ozlabs.org/patch/1308279
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-06-12 22:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 14:47 [PATCH v10 0/4] MAX9286 GMSL Support (+RDACM20) Kieran Bingham
2020-06-12 14:47 ` [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286 Kieran Bingham
2020-06-12 22:10 ` Rob Herring
2020-06-13 12:32 ` Jacopo Mondi
2020-06-15 15:02 ` Rob Herring
2020-06-15 15:19 ` Jacopo Mondi
2020-07-03 13:33 ` [PATCH v10.1] " Jacopo Mondi
2020-06-12 14:47 ` [PATCH v10 2/4] media: i2c: Add MAX9286 driver Kieran Bingham
2020-06-13 7:09 ` Manivannan Sadhasivam
2020-07-16 9:02 ` Kieran Bingham
2020-07-23 22:28 ` Sakari Ailus
2020-07-24 9:32 ` Kieran Bingham
2020-07-25 8:47 ` Sakari Ailus
2020-06-12 14:47 ` [PATCH v10 3/4] dt-bindings: media: i2c: Add bindings for IMI RDACM2x Kieran Bingham
2020-06-12 22:11 ` Rob Herring [this message]
2020-07-15 9:43 ` [PATCH v10.1 " Kieran Bingham
2020-06-12 14:47 ` [PATCH v10 4/4] media: i2c: Add RDACM20 driver Kieran Bingham
2020-07-16 9:07 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612221103.GA3902762@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=hyunk@xilinx.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).